| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202212211913.kODX3QeC-lkp@intel.com>
Date: Wed, 21 Dec 2022 19:56:49 +0800
From: kernel test robot <lkp@...el.com>
To: Siddh Raman Pant <code@...dh.me>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>,
Thomas Zimmermann <tzimmermann@...e.de>,
David Airlie <airlied@...il.com>,
Daniel Vetter <daniel@...ll.ch>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
dri-devel <dri-devel@...ts.freedesktop.org>,
linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 07/10] drm: Remove usage of deprecated DRM_DEBUG_KMS
Hi Siddh,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on next-20221220]
[also build test ERROR on linus/master]
[cannot apply to drm-misc/drm-misc-next v6.1 v6.1-rc8 v6.1-rc7 v6.1]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Siddh-Raman-Pant/drm-Remove-usage-of-deprecated-DRM_-macros/20221221-113133
patch link: https://lore.kernel.org/r/99d9fc30de75907b13228ebd262da01c3c31b042.1671566741.git.code%40siddh.me
patch subject: [PATCH 07/10] drm: Remove usage of deprecated DRM_DEBUG_KMS
config: i386-randconfig-a011-20221219
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/64f0237aa9072807bcfccd5ed22d30e7de1f8bb3
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Siddh-Raman-Pant/drm-Remove-usage-of-deprecated-DRM_-macros/20221221-113133
git checkout 64f0237aa9072807bcfccd5ed22d30e7de1f8bb3
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/gpu/drm/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
All errors (new ones prefixed by >>):
>> drivers/gpu/drm/drm_displayid.c:18:2: error: incomplete definition of type 'struct drm_device'
drm_dbg_kms(NULL, "base revision 0x%x, length %d, %d %d\n",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/drm/drm_print.h:506:25: note: expanded from macro 'drm_dbg_kms'
drm_dev_dbg(drm_ ? drm_->dev : NULL, DRM_UT_KMS, \
~~~~^
include/drm/drm_print.h:414:11: note: expanded from macro 'drm_dev_dbg'
dev, cat, fmt, ##__VA_ARGS__)
^~~
include/linux/dynamic_debug.h:247:65: note: expanded from macro '_dynamic_func_call_cls'
__dynamic_func_call_cls(__UNIQUE_ID(ddebug), cls, fmt, func, ##__VA_ARGS__)
^~~~~~~~~~~
include/linux/dynamic_debug.h:223:15: note: expanded from macro '__dynamic_func_call_cls'
func(&id, ##__VA_ARGS__); \
^~~~~~~~~~~
include/drm/drm_edid.h:30:8: note: forward declaration of 'struct drm_device'
struct drm_device;
^
1 error generated.
--
>> drivers/gpu/drm/drm_edid.c:1990:15: error: use of undeclared identifier 'dev'
drm_dbg_kms(dev, "Fixing EDID header, your hardware may be failing\n");
^
1 error generated.
--
>> drivers/gpu/drm/drm_rect.c:231:3: error: incomplete definition of type 'struct drm_device'
drm_dbg_kms(NULL, "%s" DRM_RECT_FP_FMT "\n", prefix, DRM_RECT_FP_ARG(r));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/drm/drm_print.h:506:25: note: expanded from macro 'drm_dbg_kms'
drm_dev_dbg(drm_ ? drm_->dev : NULL, DRM_UT_KMS, \
~~~~^
include/drm/drm_print.h:414:11: note: expanded from macro 'drm_dev_dbg'
dev, cat, fmt, ##__VA_ARGS__)
^~~
include/linux/dynamic_debug.h:247:65: note: expanded from macro '_dynamic_func_call_cls'
__dynamic_func_call_cls(__UNIQUE_ID(ddebug), cls, fmt, func, ##__VA_ARGS__)
^~~~~~~~~~~
include/linux/dynamic_debug.h:223:15: note: expanded from macro '__dynamic_func_call_cls'
func(&id, ##__VA_ARGS__); \
^~~~~~~~~~~
drivers/gpu/drm/drm_rect.c:231:3: note: forward declaration of 'struct drm_device'
include/drm/drm_print.h:505:15: note: expanded from macro 'drm_dbg_kms'
const struct drm_device *drm_ = (drm); \
^
drivers/gpu/drm/drm_rect.c:233:3: error: incomplete definition of type 'struct drm_device'
drm_dbg_kms(NULL, "%s" DRM_RECT_FMT "\n", prefix, DRM_RECT_ARG(r));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/drm/drm_print.h:506:25: note: expanded from macro 'drm_dbg_kms'
drm_dev_dbg(drm_ ? drm_->dev : NULL, DRM_UT_KMS, \
~~~~^
include/drm/drm_print.h:414:11: note: expanded from macro 'drm_dev_dbg'
dev, cat, fmt, ##__VA_ARGS__)
^~~
include/linux/dynamic_debug.h:247:65: note: expanded from macro '_dynamic_func_call_cls'
__dynamic_func_call_cls(__UNIQUE_ID(ddebug), cls, fmt, func, ##__VA_ARGS__)
^~~~~~~~~~~
include/linux/dynamic_debug.h:223:15: note: expanded from macro '__dynamic_func_call_cls'
func(&id, ##__VA_ARGS__); \
^~~~~~~~~~~
drivers/gpu/drm/drm_rect.c:233:3: note: forward declaration of 'struct drm_device'
include/drm/drm_print.h:505:15: note: expanded from macro 'drm_dbg_kms'
const struct drm_device *drm_ = (drm); \
^
2 errors generated.
vim +18 drivers/gpu/drm/drm_displayid.c
9
10 static int validate_displayid(const u8 *displayid, int length, int idx)
11 {
12 int i, dispid_length;
13 u8 csum = 0;
14 const struct displayid_header *base;
15
16 base = (const struct displayid_header *)&displayid[idx];
17
> 18 drm_dbg_kms(NULL, "base revision 0x%x, length %d, %d %d\n",
19 base->rev, base->bytes, base->prod_id, base->ext_count);
20
21 /* +1 for DispID checksum */
22 dispid_length = sizeof(*base) + base->bytes + 1;
23 if (dispid_length > length - idx)
24 return -EINVAL;
25
26 for (i = 0; i < dispid_length; i++)
27 csum += displayid[idx + i];
28 if (csum) {
29 pr_notice("DisplayID checksum invalid, remainder is %d\n", csum);
30 return -EINVAL;
31 }
32
33 return 0;
34 }
35
--
0-DAY CI Kernel Test Service
https://01.org/lkp
View attachment "config" of type "text/plain" (133842 bytes)
Powered by blists - more mailing lists