[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202212211958.lPjx2jaC-lkp@intel.com>
Date: Wed, 21 Dec 2022 20:06:56 +0800
From: kernel test robot <lkp@...el.com>
To: Siddh Raman Pant <code@...dh.me>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>,
Thomas Zimmermann <tzimmermann@...e.de>,
David Airlie <airlied@...il.com>,
Daniel Vetter <daniel@...ll.ch>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
dri-devel <dri-devel@...ts.freedesktop.org>,
linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 05/10] drm: Remove usage of deprecated DRM_DEBUG
Hi Siddh,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on next-20221220]
[also build test WARNING on linus/master]
[cannot apply to drm-misc/drm-misc-next v6.1 v6.1-rc8 v6.1-rc7 v6.1]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Siddh-Raman-Pant/drm-Remove-usage-of-deprecated-DRM_-macros/20221221-113133
patch link: https://lore.kernel.org/r/0fdcf7a0c9ad77e2d2252cf49fcd5d09952d1b69.1671566741.git.code%40siddh.me
patch subject: [PATCH 05/10] drm: Remove usage of deprecated DRM_DEBUG
config: i386-randconfig-a014-20221219
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/3990929cf97542bbc76cebc444540d0038b9165c
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Siddh-Raman-Pant/drm-Remove-usage-of-deprecated-DRM_-macros/20221221-113133
git checkout 3990929cf97542bbc76cebc444540d0038b9165c
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/gpu/drm/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
>> drivers/gpu/drm/drm_pci.c:250:15: warning: variable 'dev' is uninitialized when used here [-Wuninitialized]
drm_dbg_core(dev, "\n");
^~~
include/drm/drm_print.h:491:35: note: expanded from macro 'drm_dbg_core'
const struct drm_device *drm_ = (drm); \
^~~
drivers/gpu/drm/drm_pci.c:248:24: note: initialize the variable 'dev' to silence this warning
struct drm_device *dev, *tmp;
^
= NULL
1 warning generated.
vim +/dev +250 drivers/gpu/drm/drm_pci.c
236
237 /**
238 * drm_legacy_pci_exit - unregister shadow-attach legacy DRM driver
239 * @driver: DRM device driver
240 * @pdriver: PCI device driver
241 *
242 * Unregister a DRM driver shadow-attached through drm_legacy_pci_init(). This
243 * is deprecated and only used by dri1 drivers.
244 */
245 void drm_legacy_pci_exit(const struct drm_driver *driver,
246 struct pci_driver *pdriver)
247 {
248 struct drm_device *dev, *tmp;
249
> 250 drm_dbg_core(dev, "\n");
251
252 if (!(driver->driver_features & DRIVER_LEGACY)) {
253 WARN_ON(1);
254 } else {
255 mutex_lock(&legacy_dev_list_lock);
256 list_for_each_entry_safe(dev, tmp, &legacy_dev_list,
257 legacy_dev_list) {
258 if (dev->driver == driver) {
259 list_del(&dev->legacy_dev_list);
260 drm_put_dev(dev);
261 }
262 }
263 mutex_unlock(&legacy_dev_list_lock);
264 }
265 pr_info("Module unloaded\n");
266 }
267 EXPORT_SYMBOL(drm_legacy_pci_exit);
268
--
0-DAY CI Kernel Test Service
https://01.org/lkp
View attachment "config" of type "text/plain" (155113 bytes)
Powered by blists - more mailing lists