linux-kernel - Re: [PATCH v4 2/2] dt-bindings: arm: rockchip: Add EmbedFire LubanCat 1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMmci2XoF0M81mVt8zko3D3G2oTHq0ia_nZ9CPX9Xz20j92c9Q@mail.gmail.com>
Date:   Wed, 21 Dec 2022 20:12:17 +0800
From:   ty <zonyitoo@...il.com>
To:     Heiko Stübner <heiko@...ech.de>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Peter Geis <pgwipeout@...il.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org, DHDAXCW <lasstp5011@...il.com>
Subject: Re: [PATCH v4 2/2] dt-bindings: arm: rockchip: Add EmbedFire LubanCat 1

Hi, Kozlowski and Stübner,

Thank you very much for pointing me in the right direction.

> So how did you solve the comment "Does not look like properly ordered.
> Don't add stuff at the end of files/lists."? What did you change to
> solve it?

> for context sorting order in that file is alphabetical by description

I finally got it. It should be put right after the "Elgin RV1108 R1".

> You do not wrap at 75, but at some other place. Just put it to editor
> and check where is wrapping (count characters).

The original message was:

>  from: DHDAXCW <lasstp5011@...il.com>
>
> LubanCat 1 is a Rockchip RK3566 SBC based
> is developed by EmbedFire Electronics Co., Ltd.
> Mini Linux Card Type Cheap Computer Development Board
>
> Signed-off-by: Yuteng Zhong <zonyitoo@...il.com>
> Signed-off-by: DHDAXCW <lasstp5011@...il.com>

The longest line is "Mini Linux Card Type Cheap Computer Development
Board", which has 53 characters. Or ... I should use the whole line as
much as possible? Then I see why I was doing wrong. It will be fixed
in the PATCH v5.