lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20221221144534.dnkcvgpypml5u3y7@pengutronix.de>
Date:   Wed, 21 Dec 2022 15:45:34 +0100
From:   Marco Felsch <m.felsch@...gutronix.de>
To:     Adam Ford <aford173@...il.com>
Cc:     linux-arm-kernel@...ts.infradead.org, marex@...x.de,
        devicetree@...r.kernel.org, Fabio Estevam <festevam@...il.com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        aford@...conembedded.com, linux-kernel@...r.kernel.org,
        Rob Herring <robh+dt@...nel.org>,
        NXP Linux Team <linux-imx@....com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Shawn Guo <shawnguo@...nel.org>
Subject: Re: [PATCH] arm64: dts: imx8mp: Enable spba-bus on AIPS3

Hi Adam,

On 22-12-18, Adam Ford wrote:
> There is an SPBA bus on AIPS3 which includes ecspi1-3,
> UART1-3, and Flexcan1-2 according to the TRM.

LGTM

> Signed-off-by: Adam Ford <aford173@...il.com>

Reviewed-by: Marco Felsch <m.felsch@...gutronix.de>

> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index 2ce45e7cbbdf..9b0a47e7b8fd 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -719,121 +719,129 @@ aips3: bus@...00000 {
>  			#size-cells = <1>;
>  			ranges;
>  
> -			ecspi1: spi@...20000 {
> +			spba-bus@...00000 {
> +				compatible = "fsl,spba-bus", "simple-bus";
> +				reg = <0x30800000 0x100000>;
>  				#address-cells = <1>;
> -				#size-cells = <0>;
> -				compatible = "fsl,imx8mp-ecspi", "fsl,imx6ul-ecspi";
> -				reg = <0x30820000 0x10000>;
> -				interrupts = <GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>;
> -				clocks = <&clk IMX8MP_CLK_ECSPI1_ROOT>,
> -					 <&clk IMX8MP_CLK_ECSPI1_ROOT>;
> -				clock-names = "ipg", "per";
> -				assigned-clock-rates = <80000000>;
> -				assigned-clocks = <&clk IMX8MP_CLK_ECSPI1>;
> -				assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>;
> -				dmas = <&sdma1 0 7 1>, <&sdma1 1 7 2>;
> -				dma-names = "rx", "tx";
> -				status = "disabled";
> -			};
> +				#size-cells = <1>;
> +				ranges;
>  
> -			ecspi2: spi@...30000 {
> -				#address-cells = <1>;
> -				#size-cells = <0>;
> -				compatible = "fsl,imx8mp-ecspi", "fsl,imx6ul-ecspi";
> -				reg = <0x30830000 0x10000>;
> -				interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>;
> -				clocks = <&clk IMX8MP_CLK_ECSPI2_ROOT>,
> -					 <&clk IMX8MP_CLK_ECSPI2_ROOT>;
> -				clock-names = "ipg", "per";
> -				assigned-clock-rates = <80000000>;
> -				assigned-clocks = <&clk IMX8MP_CLK_ECSPI2>;
> -				assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>;
> -				dmas = <&sdma1 2 7 1>, <&sdma1 3 7 2>;
> -				dma-names = "rx", "tx";
> -				status = "disabled";
> -			};
> +				ecspi1: spi@...20000 {
> +					#address-cells = <1>;
> +					#size-cells = <0>;
> +					compatible = "fsl,imx8mp-ecspi", "fsl,imx6ul-ecspi";
> +					reg = <0x30820000 0x10000>;
> +					interrupts = <GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>;
> +					clocks = <&clk IMX8MP_CLK_ECSPI1_ROOT>,
> +						 <&clk IMX8MP_CLK_ECSPI1_ROOT>;
> +					clock-names = "ipg", "per";
> +					assigned-clock-rates = <80000000>;
> +					assigned-clocks = <&clk IMX8MP_CLK_ECSPI1>;
> +					assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>;
> +					dmas = <&sdma1 0 7 1>, <&sdma1 1 7 2>;
> +					dma-names = "rx", "tx";
> +					status = "disabled";
> +				};
>  
> -			ecspi3: spi@...40000 {
> -				#address-cells = <1>;
> -				#size-cells = <0>;
> -				compatible = "fsl,imx8mp-ecspi", "fsl,imx6ul-ecspi";
> -				reg = <0x30840000 0x10000>;
> -				interrupts = <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>;
> -				clocks = <&clk IMX8MP_CLK_ECSPI3_ROOT>,
> -					 <&clk IMX8MP_CLK_ECSPI3_ROOT>;
> -				clock-names = "ipg", "per";
> -				assigned-clock-rates = <80000000>;
> -				assigned-clocks = <&clk IMX8MP_CLK_ECSPI3>;
> -				assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>;
> -				dmas = <&sdma1 4 7 1>, <&sdma1 5 7 2>;
> -				dma-names = "rx", "tx";
> -				status = "disabled";
> -			};
> +				ecspi2: spi@...30000 {
> +					#address-cells = <1>;
> +					#size-cells = <0>;
> +					compatible = "fsl,imx8mp-ecspi", "fsl,imx6ul-ecspi";
> +					reg = <0x30830000 0x10000>;
> +					interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>;
> +					clocks = <&clk IMX8MP_CLK_ECSPI2_ROOT>,
> +						 <&clk IMX8MP_CLK_ECSPI2_ROOT>;
> +					clock-names = "ipg", "per";
> +					assigned-clock-rates = <80000000>;
> +					assigned-clocks = <&clk IMX8MP_CLK_ECSPI2>;
> +					assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>;
> +					dmas = <&sdma1 2 7 1>, <&sdma1 3 7 2>;
> +					dma-names = "rx", "tx";
> +					status = "disabled";
> +				};
>  
> -			uart1: serial@...60000 {
> -				compatible = "fsl,imx8mp-uart", "fsl,imx6q-uart";
> -				reg = <0x30860000 0x10000>;
> -				interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>;
> -				clocks = <&clk IMX8MP_CLK_UART1_ROOT>,
> -					 <&clk IMX8MP_CLK_UART1_ROOT>;
> -				clock-names = "ipg", "per";
> -				dmas = <&sdma1 22 4 0>, <&sdma1 23 4 0>;
> -				dma-names = "rx", "tx";
> -				status = "disabled";
> -			};
> +				ecspi3: spi@...40000 {
> +					#address-cells = <1>;
> +					#size-cells = <0>;
> +					compatible = "fsl,imx8mp-ecspi", "fsl,imx6ul-ecspi";
> +					reg = <0x30840000 0x10000>;
> +					interrupts = <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>;
> +					clocks = <&clk IMX8MP_CLK_ECSPI3_ROOT>,
> +						 <&clk IMX8MP_CLK_ECSPI3_ROOT>;
> +					clock-names = "ipg", "per";
> +					assigned-clock-rates = <80000000>;
> +					assigned-clocks = <&clk IMX8MP_CLK_ECSPI3>;
> +					assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>;
> +					dmas = <&sdma1 4 7 1>, <&sdma1 5 7 2>;
> +					dma-names = "rx", "tx";
> +					status = "disabled";
> +				};
>  
> -			uart3: serial@...80000 {
> -				compatible = "fsl,imx8mp-uart", "fsl,imx6q-uart";
> -				reg = <0x30880000 0x10000>;
> -				interrupts = <GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH>;
> -				clocks = <&clk IMX8MP_CLK_UART3_ROOT>,
> -					 <&clk IMX8MP_CLK_UART3_ROOT>;
> -				clock-names = "ipg", "per";
> -				dmas = <&sdma1 26 4 0>, <&sdma1 27 4 0>;
> -				dma-names = "rx", "tx";
> -				status = "disabled";
> -			};
> +				uart1: serial@...60000 {
> +					compatible = "fsl,imx8mp-uart", "fsl,imx6q-uart";
> +					reg = <0x30860000 0x10000>;
> +					interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>;
> +					clocks = <&clk IMX8MP_CLK_UART1_ROOT>,
> +						 <&clk IMX8MP_CLK_UART1_ROOT>;
> +					clock-names = "ipg", "per";
> +					dmas = <&sdma1 22 4 0>, <&sdma1 23 4 0>;
> +					dma-names = "rx", "tx";
> +					status = "disabled";
> +				};
>  
> -			uart2: serial@...90000 {
> -				compatible = "fsl,imx8mp-uart", "fsl,imx6q-uart";
> -				reg = <0x30890000 0x10000>;
> -				interrupts = <GIC_SPI 27 IRQ_TYPE_LEVEL_HIGH>;
> -				clocks = <&clk IMX8MP_CLK_UART2_ROOT>,
> -					 <&clk IMX8MP_CLK_UART2_ROOT>;
> -				clock-names = "ipg", "per";
> -				dmas = <&sdma1 24 4 0>, <&sdma1 25 4 0>;
> -				dma-names = "rx", "tx";
> -				status = "disabled";
> -			};
> +				uart3: serial@...80000 {
> +					compatible = "fsl,imx8mp-uart", "fsl,imx6q-uart";
> +					reg = <0x30880000 0x10000>;
> +					interrupts = <GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH>;
> +					clocks = <&clk IMX8MP_CLK_UART3_ROOT>,
> +						 <&clk IMX8MP_CLK_UART3_ROOT>;
> +					clock-names = "ipg", "per";
> +					dmas = <&sdma1 26 4 0>, <&sdma1 27 4 0>;
> +					dma-names = "rx", "tx";
> +					status = "disabled";
> +				};
>  
> -			flexcan1: can@...c0000 {
> -				compatible = "fsl,imx8mp-flexcan";
> -				reg = <0x308c0000 0x10000>;
> -				interrupts = <GIC_SPI 142 IRQ_TYPE_LEVEL_HIGH>;
> -				clocks = <&clk IMX8MP_CLK_IPG_ROOT>,
> -					 <&clk IMX8MP_CLK_CAN1_ROOT>;
> -				clock-names = "ipg", "per";
> -				assigned-clocks = <&clk IMX8MP_CLK_CAN1>;
> -				assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_40M>;
> -				assigned-clock-rates = <40000000>;
> -				fsl,clk-source = /bits/ 8 <0>;
> -				fsl,stop-mode = <&gpr 0x10 4>;
> -				status = "disabled";
> -			};
> +				uart2: serial@...90000 {
> +					compatible = "fsl,imx8mp-uart", "fsl,imx6q-uart";
> +					reg = <0x30890000 0x10000>;
> +					interrupts = <GIC_SPI 27 IRQ_TYPE_LEVEL_HIGH>;
> +					clocks = <&clk IMX8MP_CLK_UART2_ROOT>,
> +						 <&clk IMX8MP_CLK_UART2_ROOT>;
> +					clock-names = "ipg", "per";
> +					dmas = <&sdma1 24 4 0>, <&sdma1 25 4 0>;
> +					dma-names = "rx", "tx";
> +					status = "disabled";
> +				};
>  
> -			flexcan2: can@...d0000 {
> -				compatible = "fsl,imx8mp-flexcan";
> -				reg = <0x308d0000 0x10000>;
> -				interrupts = <GIC_SPI 144 IRQ_TYPE_LEVEL_HIGH>;
> -				clocks = <&clk IMX8MP_CLK_IPG_ROOT>,
> -					 <&clk IMX8MP_CLK_CAN2_ROOT>;
> -				clock-names = "ipg", "per";
> -				assigned-clocks = <&clk IMX8MP_CLK_CAN2>;
> -				assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_40M>;
> -				assigned-clock-rates = <40000000>;
> -				fsl,clk-source = /bits/ 8 <0>;
> -				fsl,stop-mode = <&gpr 0x10 5>;
> -				status = "disabled";
> +				flexcan1: can@...c0000 {
> +					compatible = "fsl,imx8mp-flexcan";
> +					reg = <0x308c0000 0x10000>;
> +					interrupts = <GIC_SPI 142 IRQ_TYPE_LEVEL_HIGH>;
> +					clocks = <&clk IMX8MP_CLK_IPG_ROOT>,
> +						 <&clk IMX8MP_CLK_CAN1_ROOT>;
> +					clock-names = "ipg", "per";
> +					assigned-clocks = <&clk IMX8MP_CLK_CAN1>;
> +					assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_40M>;
> +					assigned-clock-rates = <40000000>;
> +					fsl,clk-source = /bits/ 8 <0>;
> +					fsl,stop-mode = <&gpr 0x10 4>;
> +					status = "disabled";
> +				};
> +
> +				flexcan2: can@...d0000 {
> +					compatible = "fsl,imx8mp-flexcan";
> +					reg = <0x308d0000 0x10000>;
> +					interrupts = <GIC_SPI 144 IRQ_TYPE_LEVEL_HIGH>;
> +					clocks = <&clk IMX8MP_CLK_IPG_ROOT>,
> +						 <&clk IMX8MP_CLK_CAN2_ROOT>;
> +					clock-names = "ipg", "per";
> +					assigned-clocks = <&clk IMX8MP_CLK_CAN2>;
> +					assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_40M>;
> +					assigned-clock-rates = <40000000>;
> +					fsl,clk-source = /bits/ 8 <0>;
> +					fsl,stop-mode = <&gpr 0x10 5>;
> +					status = "disabled";
> +				};
>  			};
>  
>  			crypto: crypto@...00000 {
> -- 
> 2.34.1
> 
> 
> 

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ