linux-kernel - Re: [PATCH REPOST] f2fs: file: drop useless initializer in expand_inode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <07bca981-edb0-aa85-28e2-ceaf58b6a519@omp.ru>
Date:   Wed, 21 Dec 2022 17:46:10 +0300
From:   Sergey Shtylyov <s.shtylyov@....ru>
To:     Yangtao Li <frank.li@...o.com>, <jaegeuk@...nel.org>,
        <chao@...nel.org>
CC:     <linux-f2fs-devel@...ts.sourceforge.net>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH REPOST] f2fs: file: drop useless initializer in
 expand_inode_data()

Hello!

On 12/21/22 6:30 AM, Yangtao Li wrote:

>> In expand_inode_data(), the 'new_size' local variable is initialized to
>> the result of i_size_read(), however this value isn't ever used,  so we
>> can drop this initializer...
>>
>> Found by Linux Verification Center (linuxtesting.org) with the SVACE static
>> analysis tool.
>>
>> Signed-off-by: Sergey Shtylyov <s.shtylyov@....ru>
>>
>> ---
>> This patch is against the 'dev' branch of Jaegeuk Kim's F2FS repo...
>> Reposting with ISP RAS mailing lists CC'ed now...
> 
> Why do you repeatedly send a patch that cannot be applied,

   Why (it does apply to your 'dev' branch)? Because of the merge window?

> and this does not have a CC on linux-kernel.vger.kernel.org.

   I normnally avoid CCing LKML as my patches are not generally interesting
to the wide public (I think)...

> Otherwise, code modification looks good to me.

   Thanx!

> Thx,
> Yangtao

MBR, Sergey