linux-kernel - Re: [PATCH for-6.2/block V3 2/2] block: Change the granularity of io ticks from ms to ns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202212212323.yoeyf3x1-lkp@intel.com>
Date:   Thu, 22 Dec 2022 00:09:40 +0800
From:   kernel test robot <lkp@...el.com>
To:     Gulam Mohamed <gulam.mohamed@...cle.com>,
        linux-block@...r.kernel.org
Cc:     oe-kbuild-all@...ts.linux.dev, axboe@...nel.dk,
        philipp.reisner@...bit.com, lars.ellenberg@...bit.com,
        christoph.boehmwalder@...bit.com, minchan@...nel.org,
        ngupta@...are.org, senozhatsky@...omium.org, colyli@...e.de,
        kent.overstreet@...il.com, agk@...hat.com, snitzer@...nel.org,
        dm-devel@...hat.com, song@...nel.org, dan.j.williams@...el.com,
        vishal.l.verma@...el.com, dave.jiang@...el.com,
        ira.weiny@...el.com, junxiao.bi@...cle.com,
        gulam.mohamed@...cle.com, martin.petersen@...cle.com,
        kch@...dia.com, drbd-dev@...ts.linbit.com,
        linux-kernel@...r.kernel.org, linux-bcache@...r.kernel.org,
        linux-raid@...r.kernel.org, nvdimm@...ts.linux.dev,
        konrad.wilk@...cle.com, joe.jin@...cle.com,
        rajesh.sivaramasubramaniom@...cle.com
Subject: Re: [PATCH for-6.2/block V3 2/2] block: Change the granularity of io
 ticks from ms to ns

Hi Gulam,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on axboe-block/for-next]
[also build test ERROR on song-md/md-next linus/master next-20221220]
[cannot apply to device-mapper-dm/for-next v6.1]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Gulam-Mohamed/block-Data-type-conversion-for-IO-accounting/20221221-121052
base:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
patch link:    https://lore.kernel.org/r/20221221040506.1174644-2-gulam.mohamed%40oracle.com
patch subject: [PATCH for-6.2/block V3 2/2] block: Change the granularity of io ticks from ms to ns
config: x86_64-rhel-8.3-func
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/afff703cb450ec3806aa1a27406d21fc4eaa1f43
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Gulam-Mohamed/block-Data-type-conversion-for-IO-accounting/20221221-121052
        git checkout afff703cb450ec3806aa1a27406d21fc4eaa1f43
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 olddefconfig
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/md/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/md/dm.c: In function 'dm_io_acct':
>> drivers/md/dm.c:507:13: error: redefinition of 'start_time'
     507 |         u64 start_time = (blk_queue_precise_io_stat(q) ?
         |             ^~~~~~~~~~
   drivers/md/dm.c:501:13: note: previous definition of 'start_time' with type 'u64' {aka 'long long unsigned int'}
     501 |         u64 start_time = io->start_time;
         |             ^~~~~~~~~~


vim +/start_time +507 drivers/md/dm.c

   497	
   498	static void dm_io_acct(struct dm_io *io, bool end)
   499	{
   500		struct dm_stats_aux *stats_aux = &io->stats_aux;
   501		u64 start_time = io->start_time;
   502		struct mapped_device *md = io->md;
   503		struct bio *bio = io->orig_bio;
   504		unsigned int sectors;
   505		struct request_queue *q = bdev_get_queue(bio->bi_bdev);
   506	
 > 507		u64 start_time = (blk_queue_precise_io_stat(q) ?
   508					nsecs_to_jiffies(io->start_time) :
   509					io->start_time);
   510	
   511		/*
   512		 * If REQ_PREFLUSH set, don't account payload, it will be
   513		 * submitted (and accounted) after this flush completes.
   514		 */
   515		if (bio_is_flush_with_data(bio))
   516			sectors = 0;
   517		else if (likely(!(dm_io_flagged(io, DM_IO_WAS_SPLIT))))
   518			sectors = bio_sectors(bio);
   519		else
   520			sectors = io->sectors;
   521	
   522		if (!end)
   523			bdev_start_io_acct(bio->bi_bdev, sectors, bio_op(bio),
   524					   start_time);
   525		else
   526			bdev_end_io_acct(bio->bi_bdev, bio_op(bio), start_time);
   527	
   528		if (static_branch_unlikely(&stats_enabled) &&
   529		    unlikely(dm_stats_used(&md->stats))) {
   530			sector_t sector;
   531	
   532			if (likely(!dm_io_flagged(io, DM_IO_WAS_SPLIT)))
   533				sector = bio->bi_iter.bi_sector;
   534			else
   535				sector = bio_end_sector(bio) - io->sector_offset;
   536	
   537			dm_stats_account_io(&md->stats, bio_data_dir(bio),
   538					    sector, sectors,
   539					    end, start_time, stats_aux);
   540		}
   541	}
   542	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (171733 bytes)