| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202212220045.BUEgURHq-lkp@intel.com>
Date: Thu, 22 Dec 2022 00:29:55 +0800
From: kernel test robot <lkp@...el.com>
To: Gulam Mohamed <gulam.mohamed@...cle.com>,
linux-block@...r.kernel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
axboe@...nel.dk, philipp.reisner@...bit.com,
lars.ellenberg@...bit.com, christoph.boehmwalder@...bit.com,
minchan@...nel.org, ngupta@...are.org, senozhatsky@...omium.org,
colyli@...e.de, kent.overstreet@...il.com, agk@...hat.com,
snitzer@...nel.org, dm-devel@...hat.com, song@...nel.org,
dan.j.williams@...el.com, vishal.l.verma@...el.com,
dave.jiang@...el.com, ira.weiny@...el.com, junxiao.bi@...cle.com,
gulam.mohamed@...cle.com, martin.petersen@...cle.com,
kch@...dia.com, drbd-dev@...ts.linbit.com,
linux-kernel@...r.kernel.org, linux-bcache@...r.kernel.org,
linux-raid@...r.kernel.org, nvdimm@...ts.linux.dev,
konrad.wilk@...cle.com, joe.jin@...cle.com,
rajesh.sivaramasubramaniom@...cle.com
Subject: Re: [PATCH for-6.2/block V3 1/2] block: Data type conversion for IO
accounting
Hi Gulam,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on axboe-block/for-next]
[also build test ERROR on song-md/md-next linus/master next-20221220]
[cannot apply to device-mapper-dm/for-next v6.1]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Gulam-Mohamed/block-Data-type-conversion-for-IO-accounting/20221221-121052
base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
patch link: https://lore.kernel.org/r/20221221040506.1174644-1-gulam.mohamed%40oracle.com
patch subject: [PATCH for-6.2/block V3 1/2] block: Data type conversion for IO accounting
config: mips-maltaaprp_defconfig
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 98b13979fb05f3ed288a900deb843e7b27589e58)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install mips cross compiling tool for clang build
# apt-get install binutils-mipsel-linux-gnu
# https://github.com/intel-lab-lkp/linux/commit/254be08cd76a258e2d0489fac716308b416dfe6b
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Gulam-Mohamed/block-Data-type-conversion-for-IO-accounting/20221221-121052
git checkout 254be08cd76a258e2d0489fac716308b416dfe6b
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=mips olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
All errors (new ones prefixed by >>):
>> block/blk-core.c:936:14: error: call to '__cmpxchg64_unsupported' declared with 'error' attribute: cmpxchg64 not available; cpu_has_64bits may be false
if (likely(try_cmpxchg64(&part->bd_stamp, &stamp, now)))
^
include/linux/atomic/atomic-instrumented.h:2016:2: note: expanded from macro 'try_cmpxchg64'
arch_try_cmpxchg64(__ai_ptr, __ai_oldp, __VA_ARGS__); \
^
include/linux/atomic/atomic-arch-fallback.h:161:9: note: expanded from macro 'arch_try_cmpxchg64'
___r = arch_cmpxchg64((_ptr), ___o, (_new)); \
^
arch/mips/include/asm/cmpxchg.h:315:11: note: expanded from macro 'arch_cmpxchg64'
__res = __cmpxchg64_unsupported(); \
^
>> arch/mips/include/asm/cmpxchg.h:256:3: error: instruction requires a CPU feature not currently enabled
" dsra %M0, %L0, 32 \n"
^
<inline asm>:6:2: note: instantiated into assembly here
dsra $4, $2, 32
^
In file included from block/blk-core.c:16:
In file included from include/linux/module.h:13:
In file included from include/linux/stat.h:19:
In file included from include/linux/time.h:60:
In file included from include/linux/time32.h:13:
In file included from include/linux/timex.h:67:
In file included from arch/mips/include/asm/timex.h:19:
In file included from arch/mips/include/asm/cpu-type.h:12:
In file included from include/linux/smp.h:13:
In file included from include/linux/cpumask.h:13:
In file included from include/linux/atomic.h:7:
In file included from arch/mips/include/asm/atomic.h:23:
arch/mips/include/asm/cmpxchg.h:270:3: error: instruction requires a CPU feature not currently enabled
" dins %L1, %M5, 32, 32 \n"
^
<inline asm>:11:2: note: instantiated into assembly here
dins $5, $16, 32, 32
^
>> block/blk-core.c:936:14: error: call to '__cmpxchg64_unsupported' declared with 'error' attribute: cmpxchg64 not available; cpu_has_64bits may be false
if (likely(try_cmpxchg64(&part->bd_stamp, &stamp, now)))
^
include/linux/atomic/atomic-instrumented.h:2016:2: note: expanded from macro 'try_cmpxchg64'
arch_try_cmpxchg64(__ai_ptr, __ai_oldp, __VA_ARGS__); \
^
include/linux/atomic/atomic-arch-fallback.h:161:9: note: expanded from macro 'arch_try_cmpxchg64'
___r = arch_cmpxchg64((_ptr), ___o, (_new)); \
^
arch/mips/include/asm/cmpxchg.h:315:11: note: expanded from macro 'arch_cmpxchg64'
__res = __cmpxchg64_unsupported(); \
^
>> arch/mips/include/asm/cmpxchg.h:256:3: error: instruction requires a CPU feature not currently enabled
" dsra %M0, %L0, 32 \n"
^
<inline asm>:6:2: note: instantiated into assembly here
dsra $4, $2, 32
^
In file included from block/blk-core.c:16:
In file included from include/linux/module.h:13:
In file included from include/linux/stat.h:19:
In file included from include/linux/time.h:60:
In file included from include/linux/time32.h:13:
In file included from include/linux/timex.h:67:
In file included from arch/mips/include/asm/timex.h:19:
In file included from arch/mips/include/asm/cpu-type.h:12:
In file included from include/linux/smp.h:13:
In file included from include/linux/cpumask.h:13:
In file included from include/linux/atomic.h:7:
In file included from arch/mips/include/asm/atomic.h:23:
arch/mips/include/asm/cmpxchg.h:270:3: error: instruction requires a CPU feature not currently enabled
" dins %L1, %M5, 32, 32 \n"
^
<inline asm>:11:2: note: instantiated into assembly here
dins $5, $16, 32, 32
^
>> block/blk-core.c:936:14: error: call to '__cmpxchg64_unsupported' declared with 'error' attribute: cmpxchg64 not available; cpu_has_64bits may be false
if (likely(try_cmpxchg64(&part->bd_stamp, &stamp, now)))
^
include/linux/atomic/atomic-instrumented.h:2016:2: note: expanded from macro 'try_cmpxchg64'
arch_try_cmpxchg64(__ai_ptr, __ai_oldp, __VA_ARGS__); \
^
include/linux/atomic/atomic-arch-fallback.h:161:9: note: expanded from macro 'arch_try_cmpxchg64'
___r = arch_cmpxchg64((_ptr), ___o, (_new)); \
^
arch/mips/include/asm/cmpxchg.h:315:11: note: expanded from macro 'arch_cmpxchg64'
__res = __cmpxchg64_unsupported(); \
^
>> arch/mips/include/asm/cmpxchg.h:256:3: error: instruction requires a CPU feature not currently enabled
" dsra %M0, %L0, 32 \n"
^
<inline asm>:6:2: note: instantiated into assembly here
dsra $4, $2, 32
^
In file included from block/blk-core.c:16:
In file included from include/linux/module.h:13:
In file included from include/linux/stat.h:19:
In file included from include/linux/time.h:60:
In file included from include/linux/time32.h:13:
In file included from include/linux/timex.h:67:
In file included from arch/mips/include/asm/timex.h:19:
In file included from arch/mips/include/asm/cpu-type.h:12:
In file included from include/linux/smp.h:13:
In file included from include/linux/cpumask.h:13:
In file included from include/linux/atomic.h:7:
In file included from arch/mips/include/asm/atomic.h:23:
arch/mips/include/asm/cmpxchg.h:270:3: error: instruction requires a CPU feature not currently enabled
" dins %L1, %M5, 32, 32 \n"
^
<inline asm>:11:2: note: instantiated into assembly here
dins $5, $8, 32, 32
^
9 errors generated.
vim +936 block/blk-core.c
929
930 void update_io_ticks(struct block_device *part, u64 now, bool end)
931 {
932 u64 stamp;
933 again:
934 stamp = READ_ONCE(part->bd_stamp);
935 if (unlikely(time_after64(now, stamp))) {
> 936 if (likely(try_cmpxchg64(&part->bd_stamp, &stamp, now)))
937 __part_stat_add(part, io_ticks, end ? now - stamp : 1);
938 }
939 if (part->bd_partno) {
940 part = bdev_whole(part);
941 goto again;
942 }
943 }
944
--
0-DAY CI Kernel Test Service
https://01.org/lkp
View attachment "config" of type "text/plain" (74781 bytes)
Powered by blists - more mailing lists