linux-kernel - Re: [PATCH v4 1/1] i2c: designware: use casting of u64 in clock multiplication to avoid overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y6M7hHVcEEyqg/b2@smile.fi.intel.com>
Date:   Wed, 21 Dec 2022 18:59:48 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     "Hawa, Hanna" <hhhawa@...zon.com>
Cc:     wsa@...nel.org, jarkko.nikula@...ux.intel.com,
        mika.westerberg@...ux.intel.com, jsd@...ihalf.com,
        linus.walleij@...aro.org, ben-linux@...ff.org,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        dwmw@...zon.co.uk, benh@...zon.com, ronenk@...zon.com,
        talel@...zon.com, jonnyc@...zon.com, hanochu@...zon.com,
        farbere@...zon.com, itamark@...zon.com,
        Lareine Khawaly <lareine@...zon.com>
Subject: Re: [PATCH v4 1/1] i2c: designware: use casting of u64 in clock
 multiplication to avoid overflow

On Tue, Dec 20, 2022 at 09:43:25PM +0200, Hawa, Hanna wrote:
> On 12/20/2022 9:27 PM, Andy Shevchenko wrote:
> > Thinking more on this, I would probably replace the order of arguments to make
> > it ' + offset - N' in each case. Since plus will be on the previous line and
> > become first it will be easier to parse the arithmetical expression.
> 
> Do you want this change in the same patch? i don't think it's related here..
> I can push separated change

Up to you. If you think it's not suitable, then don't change.

-- 
With Best Regards,
Andy Shevchenko