linux-kernel - Re: [RFC PATCH 6/7] ARM: dts: stm32: add ETZPC as a system bus for STM32MP15x boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2e7c901c-e322-ded6-b170-6d2436d74c0f@kernel.org>
Date:   Thu, 22 Dec 2022 11:30:17 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Gatien Chevallier <gatien.chevallier@...s.st.com>,
        alexandre.torgue@...s.st.com, robh+dt@...nel.org,
        Oleksii_Moisieiev@...m.com, linus.walleij@...aro.org,
        gregkh@...uxfoundation.org
Cc:     linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        loic.pallardy@...com, devicetree@...r.kernel.org,
        mark.rutland@....com, arnd@...db.de
Subject: Re: [RFC PATCH 6/7] ARM: dts: stm32: add ETZPC as a system bus for
 STM32MP15x boards

On 21/12/2022 18:30, Gatien Chevallier wrote:
> The STM32 System Bus is an internal bus on which devices are connected.
> ETZPC is a peripheral overseeing the firewall bus that configures
> and control access to the peripherals connected on it.
> 
> For more information on which peripheral is securable, please read
> the STM32MP15 reference manual.
> 
> Signed-off-by: Gatien Chevallier <gatien.chevallier@...s.st.com>
> ---
>  arch/arm/boot/dts/stm32mp151.dtsi | 2737 +++++++++++++++--------------
>  1 file changed, 1406 insertions(+), 1331 deletions(-)
>  
> -		lptimer1: timer@...09000 {
> +		etzpc: etzpc@...07000 {

Node names should be generic.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

> +			compatible = "st,stm32mp15-sys-bus";
> +			reg = <0x5c007000 0x400>;
>  			#address-cells = <1>;
> -			#size-cells = <0>;
> -			compatible = "st,stm32-lptimer";
> -			reg = <0x40009000 0x400>;
> -			interrupts-extended = <&exti 47 IRQ_TYPE_LEVEL_HIGH>;
> -			clocks = <&rcc LPTIM1_K>;
> -			clock-names = "mux";
> -			wakeup-source;
> -			status = "disabled";

Why entire bus is disabled? What resources do you miss?

> +			#size-cells = <1>;
> +			feature-domain-controller;
> +			#feature-domain-cells = <2>;
> +			ranges;
>  
Best regards,
Krzysztof