linux-kernel - RE: [PATCH 2/3] hwrng: starfive - Add TRNG driver for StarFive SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2684abf708f145f4b49ec1680c1ddb87@EXMBX168.cuchost.com>
Date:   Thu, 22 Dec 2022 10:29:41 +0000
From:   JiaJie Ho <jiajie.ho@...rfivetech.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Olivia Mackall <olivia@...enic.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
CC:     Emil Renner Berthing <kernel@...il.dk>,
        Conor Dooley <conor.dooley@...rochip.com>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>
Subject: RE: [PATCH 2/3] hwrng: starfive - Add TRNG driver for StarFive SoC



> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: Thursday, December 22, 2022 5:44 PM
> To: JiaJie Ho <jiajie.ho@...rfivetech.com>; Olivia Mackall
> <olivia@...enic.com>; Herbert Xu <herbert@...dor.apana.org.au>; Rob
> Herring <robh+dt@...nel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@...aro.org>
> Cc: Emil Renner Berthing <kernel@...il.dk>; Conor Dooley
> <conor.dooley@...rochip.com>; linux-crypto@...r.kernel.org;
> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org; linux-
> riscv@...ts.infradead.org
> Subject: Re: [PATCH 2/3] hwrng: starfive - Add TRNG driver for StarFive SoC
> 
> > How do I properly handle __maybe_unused functions in this scenario?
> 
> The same as in other files. Use `git grep`
> 
> > Will it help if I add #define as follows:
> >
> > #ifdef CONFIG_PM
> > #define STARFIVE_RNG_PM_OPS (&starfive_rng_pm_ops) #else #define
> > STARFIVE_RNG_PM_OPS NULL #endif
> 
> I talked only about of_match_ptr(). This is not of_match_ptr and should have
> its own syntax (pm_sleep_ptr + static DEFINE_SIMPLE_DEV_PM_OPS)
> 
> >
> > static struct platform_driver starfive_trng_driver = {
> >         .probe  = starfive_trng_probe,
> >         .driver = {
> >                 .name           = "starfive-trng",
> >                 .pm             = STARFIVE_RNG_PM_OPS,
> >                 .of_match_table = of_match_ptr(trng_dt_ids),
> >         },
> > };
> >
> > I did build the patches with the tools mentioned but did not get warnings.
> > Do I need a specific version, or have I done something wrong?
> 
> You just need proper COMPILE_TEST config with OF disabled.
> 

I'll update the patch accordingly.
Thanks again for the comments and suggestions.

Regards,
Jia Jie