linux-kernel - [PATCH linux-next] lib: Dhrystone: initialize ret value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 24 Dec 2022 13:06:40 +0800
From:   Zhouyi Zhou <zhouzhouyi@...il.com>
To:     nathan@...nel.org, ndesaulniers@...gle.com, trix@...hat.com,
        akpm@...ux-foundation.org, geert+renesas@...der.be,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev
Cc:     Zhouyi Zhou <zhouzhouyi@...il.com>
Subject: [PATCH linux-next] lib: Dhrystone: initialize ret value

Initialize ret value whenever 'if' condition is false in dhry_run_set.

Signed-off-by: Zhouyi Zhou <zhouzhouyi@...il.com>
---
Dear Developers:
When I invoke make bzImage LLVM=1, clang complains followings:
lib/dhry_run.c:61:6: error: variable 'ret' is used uninitialized whenever 'if' condition is false

Fix above complain by initialize the ret value.

Thanks
Zhouyi
--
 lib/dhry_run.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/dhry_run.c b/lib/dhry_run.c
index 31a1d442e4a0..be86e5126c29 100644
--- a/lib/dhry_run.c
+++ b/lib/dhry_run.c
@@ -64,6 +64,7 @@ static int dhry_run_set(const char *val, const struct kernel_param *kp)
 			return ret;
 	} else {
 		dhry_run = true;
+		ret = 0;
 	}
 
 	if (dhry_run && system_state == SYSTEM_RUNNING)
-- 
2.34.1