linux-kernel - RE: [EXT] Re: [PATCH v2] USB: gadget: Add ID numbers to configfs-gadget driver names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <HE1PR0401MB2331C0314D27002E5F3FC17288EF9@HE1PR0401MB2331.eurprd04.prod.outlook.com>
Date:   Sun, 25 Dec 2022 03:07:12 +0000
From:   Frank Li <frank.li@....com>
To:     Andrzej Pietrasiewicz <andrzej.p@...labora.com>,
        Chanh Nguyen <chanh@...amperecomputing.com>,
        OpenBMC Maillist <openbmc@...ts.ozlabs.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Dan Vacura <w36195@...orola.com>,
        Jakob Koschel <jakobkoschel@...il.com>,
        Alan Stern <stern@...land.harvard.edu>,
        Vijayavardhan Vennapusa <vvreddy@...eaurora.org>,
        Rondreis <linhaoguo86@...il.com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Open Source Submission <patches@...erecomputing.com>
Subject: RE: [EXT] Re: [PATCH v2] USB: gadget: Add ID numbers to
 configfs-gadget driver names

> 
> I'm wondering if it maybe makes more sense to use the gadget name as a
> suffix
> instead?
> 
>         gi->composite.gadget_driver.driver.name =
>                 kasprintf(GFP_KERNEL, "configfs-gadget.%s" name);
> 
> So that when you
> 
> mkdir g1
> 
> you will ultimately see /sys/bus/gadget/drivers/configfs-gadget.g1
> 
> instead of /sys/bus/gadget/drivers/configfs-gadget.0
> 
> Gadget names are guaranteed to be unique because they are created
> as sibling subdirectories in configfs. Your patch would then be greatly
> simplified (no need for ida).

I vote this ways. 

Best regards
Frank Li

> 
> Regards,
> 
> Andrzej
>