linux-kernel - Re: [PATCH v12 2/2] arm64: dts: qcom: sagit: add initial device tree for sagit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 27 Dec 2022 18:09:13 +0300
From:   Dzmitry Sankouski <dsankouski@...il.com>
To:     Marijn Suijten <marijn.suijten@...ainline.org>
Cc:     linux-kernel@...r.kernel.org, Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Kees Cook <keescook@...omium.org>,
        Anton Vorontsov <anton@...msg.org>,
        Colin Cross <ccross@...roid.com>,
        Tony Luck <tony.luck@...el.com>,
        "open list:ARM/QUALCOMM SUPPORT" <linux-arm-msm@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>
Subject: Re: [PATCH v12 2/2] arm64: dts: qcom: sagit: add initial device tree
 for sagit

Thanks for the note, I'll send the fix.

чт, 22 дек. 2022 г. в 14:59, Marijn Suijten <marijn.suijten@...ainline.org>:
>
> On 2022-11-12 23:33:00, Dzmitry Sankouski wrote:
> > New device support - Xiaomi Mi6 phone
>
> <snip>
>
> > diff --git a/arch/arm64/boot/dts/qcom/pm8998.dtsi b/arch/arm64/boot/dts/qcom/pm8998.dtsi
> > index 6a0e14382be8..6a5854333b2b 100644
> > --- a/arch/arm64/boot/dts/qcom/pm8998.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/pm8998.dtsi
> > @@ -52,6 +52,14 @@ pm8998_pwrkey: pwrkey {
> >                               bias-pull-up;
> >                               linux,code = <KEY_POWER>;
> >                       };
> > +
> > +                     pm8998_resin: resin {
> > +                             compatible = "qcom,pm8941-resin";
> > +                             interrupts = <GIC_SPI 0x8 1 IRQ_TYPE_EDGE_BOTH>;
> > +                             debounce = <15625>;
> > +                             bias-pull-up;
> > +                             status = "disabled";
> > +                     };
>
> This should have been a separate patch, one that deduplicated
> overlapping nodes with existing msm8998 / sdm845 boards which all add
> this node individually to &pm8998_pon.
>
> What's more, their override has the same node name and will be merged
> with this one without setting status = "okay", leading to all those
> boards suddenly having a broken resin key because they inherit your
> status="disabled".
>
> Can you send a fix to address that, with proper Fixes: tag?
>
> - Marijn
>
> >               };
> >
> >               pm8998_temp: temp-alarm@...0 {
> > --
> > 2.30.2
> >