linux-kernel - WARNING: proc registration bug in clusterip_tg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAO4mrffVCyXXy_fcvw5iK6srAsL2Ziwi5FzsXoGHZ0MGxGTY4Q@mail.gmail.com>
Date:   Tue, 27 Dec 2022 23:09:21 +0800
From:   Wei Chen <harperchen1110@...il.com>
To:     akpm@...ux-foundation.org, adobriyan@...il.com,
        muchun.song@...ux.dev, brauner@...nel.org,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        pablo@...filter.org, kadlec@...filter.org, fw@...len.de,
        netfilter-devel@...r.kernel.org, coreteam@...filter.org,
        netdev@...r.kernel.org, syzkaller-bugs@...glegroups.com,
        syzbot <syzkaller@...glegroups.com>
Subject: WARNING: proc registration bug in clusterip_tg_check

Dear Linux Developers,

Recently, when using our tool to fuzz kernel, the following crash was
triggered. Although this crash has happened and fixed
https://syzkaller.appspot.com/bug?id=ebe48d4bdb85f09cb87ee94052a7911be0c497b1,
it persists in the latest kernel version.

HEAD commit: e45fb347b630 Linux 6.1.0-next-20221220
git tree: linux-next
compiler: clang 12.0.0
console output:
https://drive.google.com/file/d/10FADp0RJlM5p0dRvxSpaNqS8OJUIxQ9p/view?usp=share_link
kernel config: https://drive.google.com/file/d/1mMD6aopttKDGK4aYUlgiwAk6bOQHivd-/view?usp=share_link
syz repro: https://drive.google.com/file/d/1n8MmOduvafNwOvUCOr6NCVTrYln67Fgy/view?usp=share_link

IMPORTANT: if you fix the bug, please add the following tag to the commit:
Reported-by: Wei Chen <harperchen1110@...il.com>

------------[ cut here ]------------
proc_dir_entry 'ipt_CLUSTERIP/10.1.1.2' already registered
WARNING: CPU: 0 PID: 27382 at fs/proc/generic.c:377
proc_register+0x1df/0x330 fs/proc/generic.c:376
Modules linked in:
CPU: 0 PID: 27382 Comm: syz-executor.0 Not tainted 6.1.0-next-20221220 #6
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS
rel-1.13.0-48-gd9c812dda519-prebuilt.qemu.org 04/01/2014
RIP: 0010:proc_register+0x1df/0x330 fs/proc/generic.c:376
Code: 48 8b 1c 24 48 8d bb a0 00 00 00 e8 9b b9 d4 ff 48 8b b3 a0 00
00 00 48 c7 c7 e1 81 63 85 48 8b 54 24 08 31 c0 e8 11 4b a7 ff <0f> 0b
48 c7 c7 48 76 e8 86 e8 03 c4 46 03 48 8b 5c 24 18 48 89 df
RSP: 0018:ffffc900009d7880 EFLAGS: 00010246
RAX: 9d0fa4778954f400 RBX: ffff88803d052d80 RCX: 0000000000040000
RDX: ffffc90001161000 RSI: 000000000000087b RDI: 000000000000087c
RBP: ffff88804a1d6398 R08: ffffffff81179fd9 R09: 0000000000000000
R10: 0001ffffffffffff R11: ffff88803e614000 R12: 0000000000000000
R13: ffff88804a1d6240 R14: ffff88804a1d6388 R15: 0000000000000008
FS:  00007f90df3c4700(0000) GS:ffff88807dc00000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f90df3c3db8 CR3: 00000000481a9000 CR4: 00000000003506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000600
Call Trace:
 <TASK>
 proc_create_data+0x136/0x170 fs/proc/generic.c:578
 clusterip_config_init net/ipv4/netfilter/ipt_CLUSTERIP.c:292 [inline]
 clusterip_tg_check+0x860/0xf50 net/ipv4/netfilter/ipt_CLUSTERIP.c:517
 xt_check_target+0x275/0x700 net/netfilter/x_tables.c:1038
 check_target net/ipv4/netfilter/ip_tables.c:512 [inline]
 find_check_entry net/ipv4/netfilter/ip_tables.c:554 [inline]
 translate_table+0xc73/0xfd0 net/ipv4/netfilter/ip_tables.c:718
 do_replace net/ipv4/netfilter/ip_tables.c:1136 [inline]
 do_ipt_set_ctl+0x1407/0x1720 net/ipv4/netfilter/ip_tables.c:1630
 nf_setsockopt+0x1a6/0x1c0 net/netfilter/nf_sockopt.c:101
 ip_setsockopt+0xe2/0x100 net/ipv4/ip_sockglue.c:1445
 tcp_setsockopt+0x8c/0xa0 net/ipv4/tcp.c:3801
 sock_common_setsockopt+0x5d/0x70 net/core/sock.c:3663
 __sys_setsockopt+0x1c8/0x230 net/socket.c:2246
 __do_sys_setsockopt net/socket.c:2257 [inline]
 __se_sys_setsockopt net/socket.c:2254 [inline]
 __x64_sys_setsockopt+0x62/0x70 net/socket.c:2254
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x2b/0x70 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x4697f9
Code: f7 d8 64 89 02 b8 ff ff ff ff c3 66 0f 1f 44 00 00 48 89 f8 48
89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d
01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f90df3c3c48 EFLAGS: 00000246 ORIG_RAX: 0000000000000036
RAX: ffffffffffffffda RBX: 000000000077c038 RCX: 00000000004697f9
RDX: 0000000000000040 RSI: 0000000000000000 RDI: 0000000000000003
RBP: 00000000004d29e9 R08: 00000000000002f0 R09: 0000000000000000
R10: 0000000020000b00 R11: 0000000000000246 R12: 000000000077c038
R13: 0000000000000000 R14: 000000000077c038 R15: 00007ffd8e91dd80
 </TASK>
---[ end trace 0000000000000000 ]---

Best,
Wei