linux-kernel - Re: [PATCH v1 1/1] uuid: Decouple guid_t and uuid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202212282358.31ZqIizq-lkp@intel.com>
Date:   Wed, 28 Dec 2022 23:42:31 +0800
From:   kernel test robot <lkp@...el.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        linux-kernel@...r.kernel.org
Cc:     oe-kbuild-all@...ts.linux.dev, Christoph Hellwig <hch@....de>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linux Memory Management List <linux-mm@...ck.org>
Subject: Re: [PATCH v1 1/1] uuid: Decouple guid_t and uuid_le types and
 respective macros

Hi Andy,

I love your patch! Perhaps something to improve:

[auto build test WARNING on hch-configfs/for-next]
[also build test WARNING on akpm-mm/mm-everything linus/master v6.2-rc1 next-20221226]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/uuid-Decouple-guid_t-and-uuid_le-types-and-respective-macros/20221228-213942
base:   git://git.infradead.org/users/hch/configfs.git for-next
patch link:    https://lore.kernel.org/r/20221228133616.69278-1-andriy.shevchenko%40linux.intel.com
patch subject: [PATCH v1 1/1] uuid: Decouple guid_t and uuid_le types and respective macros
config: x86_64-allyesconfig
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/419ed69a685704bcd3f5f617181e305fb06bce0d
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Andy-Shevchenko/uuid-Decouple-guid_t-and-uuid_le-types-and-respective-macros/20221228-213942
        git checkout 419ed69a685704bcd3f5f617181e305fb06bce0d
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 olddefconfig
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/misc/mei/hdcp/ drivers/misc/mei/pxp/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In file included from drivers/misc/mei/hdcp/mei_hdcp.c:21:
   include/linux/uuid.h:24:1: error: incompatible types when initializing type 'unsigned char' using type 'guid_t'
      24 | ((guid_t)                                                               \
         | ^
   drivers/misc/mei/hdcp/mei_hdcp.c:862:23: note: in expansion of macro 'GUID_INIT'
     862 | #define MEI_UUID_HDCP GUID_INIT(0xB638AB7E, 0x94E2, 0x4EA2, 0xA5, \
         |                       ^~~~~~~~~
   drivers/misc/mei/hdcp/mei_hdcp.c:866:19: note: in expansion of macro 'MEI_UUID_HDCP'
     866 |         { .uuid = MEI_UUID_HDCP, .version = MEI_CL_VERSION_ANY },
         |                   ^~~~~~~~~~~~~
>> drivers/misc/mei/hdcp/mei_hdcp.c:865:55: warning: missing braces around initializer [-Wmissing-braces]
     865 | static const struct mei_cl_device_id mei_hdcp_tbl[] = {
         |                                                       ^
--
   In file included from drivers/misc/mei/pxp/mei_pxp.c:16:
   include/linux/uuid.h:24:1: error: incompatible types when initializing type 'unsigned char' using type 'guid_t'
      24 | ((guid_t)                                                               \
         | ^
   drivers/misc/mei/pxp/mei_pxp.c:209:22: note: in expansion of macro 'GUID_INIT'
     209 | #define MEI_GUID_PXP GUID_INIT(0xfbf6fcf1, 0x96cf, 0x4e2e, 0xA6, \
         |                      ^~~~~~~~~
   drivers/misc/mei/pxp/mei_pxp.c:213:19: note: in expansion of macro 'MEI_GUID_PXP'
     213 |         { .uuid = MEI_GUID_PXP, .version = MEI_CL_VERSION_ANY },
         |                   ^~~~~~~~~~~~
>> drivers/misc/mei/pxp/mei_pxp.c:212:48: warning: missing braces around initializer [-Wmissing-braces]
     212 | static struct mei_cl_device_id mei_pxp_tbl[] = {
         |                                                ^


vim +865 drivers/misc/mei/hdcp/mei_hdcp.c

64e9bbdd9588ad Ramalingam C     2019-02-21  861  
64e9bbdd9588ad Ramalingam C     2019-02-21  862  #define MEI_UUID_HDCP GUID_INIT(0xB638AB7E, 0x94E2, 0x4EA2, 0xA5, \
64e9bbdd9588ad Ramalingam C     2019-02-21  863  				0x52, 0xD1, 0xC5, 0x4B, 0x62, 0x7F, 0x04)
64e9bbdd9588ad Ramalingam C     2019-02-21  864  
50bf73bdce8efc Rikard Falkeborn 2020-06-11 @865  static const struct mei_cl_device_id mei_hdcp_tbl[] = {
64e9bbdd9588ad Ramalingam C     2019-02-21  866  	{ .uuid = MEI_UUID_HDCP, .version = MEI_CL_VERSION_ANY },
64e9bbdd9588ad Ramalingam C     2019-02-21  867  	{ }
64e9bbdd9588ad Ramalingam C     2019-02-21  868  };
64e9bbdd9588ad Ramalingam C     2019-02-21  869  MODULE_DEVICE_TABLE(mei, mei_hdcp_tbl);
64e9bbdd9588ad Ramalingam C     2019-02-21  870  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (291978 bytes)