lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Thu, 29 Dec 2022 00:43:04 +0800
From:   kernel test robot <lkp@...el.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        linux-kernel@...r.kernel.org
Cc:     llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        Christoph Hellwig <hch@....de>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linux Memory Management List <linux-mm@...ck.org>
Subject: Re: [PATCH v1 1/1] uuid: Decouple guid_t and uuid_le types and
 respective macros

Hi Andy,

I love your patch! Yet something to improve:

[auto build test ERROR on hch-configfs/for-next]
[also build test ERROR on akpm-mm/mm-everything linus/master v6.2-rc1 next-20221226]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/uuid-Decouple-guid_t-and-uuid_le-types-and-respective-macros/20221228-213942
base:   git://git.infradead.org/users/hch/configfs.git for-next
patch link:    https://lore.kernel.org/r/20221228133616.69278-1-andriy.shevchenko%40linux.intel.com
patch subject: [PATCH v1 1/1] uuid: Decouple guid_t and uuid_le types and respective macros
config: x86_64-randconfig-a006-20221226
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/419ed69a685704bcd3f5f617181e305fb06bce0d
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Andy-Shevchenko/uuid-Decouple-guid_t-and-uuid_le-types-and-respective-macros/20221228-213942
        git checkout 419ed69a685704bcd3f5f617181e305fb06bce0d
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/misc/mei/hdcp/ drivers/misc/mei/pxp/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All error/warnings (new ones prefixed by >>):

>> drivers/misc/mei/hdcp/mei_hdcp.c:866:12: error: initializing '__u8' (aka 'unsigned char') with an expression of incompatible type 'guid_t'
           { .uuid = MEI_UUID_HDCP, .version = MEI_CL_VERSION_ANY },
                     ^~~~~~~~~~~~~
   drivers/misc/mei/hdcp/mei_hdcp.c:862:23: note: expanded from macro 'MEI_UUID_HDCP'
   #define MEI_UUID_HDCP GUID_INIT(0xB638AB7E, 0x94E2, 0x4EA2, 0xA5, \
                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/uuid.h:23:62: note: expanded from macro 'GUID_INIT'
   #define GUID_INIT(a, b, c, d0, d1, d2, d3, d4, d5, d6, d7)                      \
                                                                                   ^
>> drivers/misc/mei/hdcp/mei_hdcp.c:866:12: warning: suggest braces around initialization of subobject [-Wmissing-braces]
           { .uuid = MEI_UUID_HDCP, .version = MEI_CL_VERSION_ANY },
                     ^~~~~~~~~~~~~
                     {            }
   drivers/misc/mei/hdcp/mei_hdcp.c:862:23: note: expanded from macro 'MEI_UUID_HDCP'
   #define MEI_UUID_HDCP GUID_INIT(0xB638AB7E, 0x94E2, 0x4EA2, 0xA5, \
                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/uuid.h:23:62: note: expanded from macro 'GUID_INIT'
   #define GUID_INIT(a, b, c, d0, d1, d2, d3, d4, d5, d6, d7)                      \
                                                                                   ^
>> drivers/misc/mei/hdcp/mei_hdcp.c:869:1: error: definition of variable with array type needs an explicit size or an initializer
   MODULE_DEVICE_TABLE(mei, mei_hdcp_tbl);
   ^
   include/linux/module.h:243:21: note: expanded from macro 'MODULE_DEVICE_TABLE'
   extern typeof(name) __mod_##type##__##name##_device_table               \
                       ^
   <scratch space>:29:1: note: expanded from here
   __mod_mei__mei_hdcp_tbl_device_table
   ^
   1 warning and 2 errors generated.
--
>> drivers/misc/mei/pxp/mei_pxp.c:213:12: error: initializing '__u8' (aka 'unsigned char') with an expression of incompatible type 'guid_t'
           { .uuid = MEI_GUID_PXP, .version = MEI_CL_VERSION_ANY },
                     ^~~~~~~~~~~~
   drivers/misc/mei/pxp/mei_pxp.c:209:22: note: expanded from macro 'MEI_GUID_PXP'
   #define MEI_GUID_PXP GUID_INIT(0xfbf6fcf1, 0x96cf, 0x4e2e, 0xA6, \
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/uuid.h:23:62: note: expanded from macro 'GUID_INIT'
   #define GUID_INIT(a, b, c, d0, d1, d2, d3, d4, d5, d6, d7)                      \
                                                                                   ^
>> drivers/misc/mei/pxp/mei_pxp.c:213:12: warning: suggest braces around initialization of subobject [-Wmissing-braces]
           { .uuid = MEI_GUID_PXP, .version = MEI_CL_VERSION_ANY },
                     ^~~~~~~~~~~~
                     {           }
   drivers/misc/mei/pxp/mei_pxp.c:209:22: note: expanded from macro 'MEI_GUID_PXP'
   #define MEI_GUID_PXP GUID_INIT(0xfbf6fcf1, 0x96cf, 0x4e2e, 0xA6, \
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/uuid.h:23:62: note: expanded from macro 'GUID_INIT'
   #define GUID_INIT(a, b, c, d0, d1, d2, d3, d4, d5, d6, d7)                      \
                                                                                   ^
>> drivers/misc/mei/pxp/mei_pxp.c:216:1: error: definition of variable with array type needs an explicit size or an initializer
   MODULE_DEVICE_TABLE(mei, mei_pxp_tbl);
   ^
   include/linux/module.h:243:21: note: expanded from macro 'MODULE_DEVICE_TABLE'
   extern typeof(name) __mod_##type##__##name##_device_table               \
                       ^
   <scratch space>:180:1: note: expanded from here
   __mod_mei__mei_pxp_tbl_device_table
   ^
   1 warning and 2 errors generated.


vim +866 drivers/misc/mei/hdcp/mei_hdcp.c

64e9bbdd9588ad Ramalingam C     2019-02-21  861  
64e9bbdd9588ad Ramalingam C     2019-02-21  862  #define MEI_UUID_HDCP GUID_INIT(0xB638AB7E, 0x94E2, 0x4EA2, 0xA5, \
64e9bbdd9588ad Ramalingam C     2019-02-21  863  				0x52, 0xD1, 0xC5, 0x4B, 0x62, 0x7F, 0x04)
64e9bbdd9588ad Ramalingam C     2019-02-21  864  
50bf73bdce8efc Rikard Falkeborn 2020-06-11  865  static const struct mei_cl_device_id mei_hdcp_tbl[] = {
64e9bbdd9588ad Ramalingam C     2019-02-21 @866  	{ .uuid = MEI_UUID_HDCP, .version = MEI_CL_VERSION_ANY },
64e9bbdd9588ad Ramalingam C     2019-02-21  867  	{ }
64e9bbdd9588ad Ramalingam C     2019-02-21  868  };
64e9bbdd9588ad Ramalingam C     2019-02-21 @869  MODULE_DEVICE_TABLE(mei, mei_hdcp_tbl);
64e9bbdd9588ad Ramalingam C     2019-02-21  870  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (160386 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ