lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 29 Dec 2022 08:19:07 +0000
From:   Kyrie Wu (吴晗) <Kyrie.Wu@...iatek.com>
To:     "nicolas.dufresne@...labora.com" <nicolas.dufresne@...labora.com>,
        "mchehab@...nel.org" <mchehab@...nel.org>,
        Kyrie Wu (吴晗) <Kyrie.Wu@...iatek.com>,
        Irui Wang (王瑞) <Irui.Wang@...iatek.com>,
        "hverkuil-cisco@...all.nl" <hverkuil-cisco@...all.nl>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "bagasdotme@...il.com" <bagasdotme@...il.com>,
        "angelogioacchino.delregno@...labora.com" 
        <angelogioacchino.delregno@...labora.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "tfiga@...omium.org" <tfiga@...omium.org>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        Maoguang Meng (孟毛广) 
        <Maoguang.Meng@...iatek.com>,
        Project_Global_Chrome_Upstream_Group 
        <Project_Global_Chrome_Upstream_Group@...iatek.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Xia Jiang (江霞) <Xia.Jiang@...iatek.com>
Subject: Re: [V2] media: jpeg: Fix multi-hw judgement

On Wed, 2022-12-28 at 19:29 +0700, Bagas Sanjaya wrote:
> On Fri, Dec 16, 2022 at 11:52:47AM +0800, Irui Wang wrote:
> > From: kyrie wu <kyrie.wu@...iatek.com>
> > 
> > some chips have multi-hw, but others have only one,
> > modify the condition of multi-hw judgement
> 
> nit: s/judgement/conditional block/ ...
> 
> > -	if (list_empty(&pdev->dev.devres_head)) {
> > +	if (!jpeg->variant->hw_arch) {
> 
> ... like here (if block).
> 
> Thanks.

Hi Bagas,

I can't get your suggestion exactly.
Do you mean to change if (...) as follows:
if (jpeg->variant->hw_arch)
> 

Thanks.

Regards,
Kyrie.

Powered by blists - more mailing lists