[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20221229082103.21064-1-miles.chen@mediatek.com>
Date: Thu, 29 Dec 2022 16:21:03 +0800
From: Miles Chen <miles.chen@...iatek.com>
To: <angelogioacchino.delregno@...labora.com>
CC: <chun-jie.chen@...iatek.com>, <daniel@...rotopia.org>,
<devicetree@...r.kernel.org>, <fparent@...libre.com>,
<ikjn@...omium.org>, <johnson.wang@...iatek.com>,
<jose.exposito89@...il.com>, <kernel@...labora.com>,
<krzysztof.kozlowski+dt@...aro.org>,
<linux-arm-kernel@...ts.infradead.org>,
<linux-clk@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<linux-mediatek@...ts.infradead.org>, <matthias.bgg@...il.com>,
<miles.chen@...iatek.com>, <msp@...libre.com>,
<mturquette@...libre.com>, <nfraprado@...labora.com>,
<pablo.sun@...iatek.com>, <rex-bc.chen@...iatek.com>,
<robh+dt@...nel.org>, <ryder.lee@...nel.org>,
<sam.shih@...iatek.com>, <sboyd@...nel.org>,
<weiyi.lu@...iatek.com>, <wenst@...omium.org>,
<y.oudjana@...tonmail.com>, <yangyingliang@...wei.com>
Subject: Re: [PATCH v2 18/23] clk: mediatek: clk-mtk: Register MFG notifier in mtk_clk_simple_probe()
>In preparation for commonizing topckgen probe on various MediaTek SoCs
>clock drivers, add the ability to register the MFG MUX notifier in
>mtk_clk_simple_probe() by passing a custom notifier register function
>pointer, as this function will be slightly different across different
>SoCs.
>
>Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
>---
> drivers/clk/mediatek/clk-mtk.c | 8 ++++++++
> drivers/clk/mediatek/clk-mtk.h | 3 +++
> 2 files changed, 11 insertions(+)
>
>diff --git a/drivers/clk/mediatek/clk-mtk.c b/drivers/clk/mediatek/clk-mtk.c
>index b0a6225cd7b2..df6281492fb6 100644
>--- a/drivers/clk/mediatek/clk-mtk.c
>+++ b/drivers/clk/mediatek/clk-mtk.c
>@@ -533,6 +533,14 @@ int mtk_clk_simple_probe(struct platform_device *pdev)
> goto unregister_composites;
> }
>
>+ if (mcd->clk_notifier_func) {
>+ struct clk *mfg_mux = clk_data->hws[mcd->mfg_clk_idx]->clk;
>+
>+ r = mcd->clk_notifier_func(&pdev->dev, mfg_mux);
>+ if (r)
>+ goto unregister_clks;
>+ }
Should we have a IS_ERR_OR_NULL() check for clk_data->hws[mcd->mfg_clk_idx]?
thanks,
Miles
>+
> r = of_clk_add_hw_provider(node, of_clk_hw_onecell_get, clk_data);
> if (r)
Powered by blists - more mailing lists