linux-kernel - Re: [PATCH v2] ARM: dts: dove.dtsi: Move ethphy to fix schema error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y6zuJrb+8j+XCksN@lunn.ch>
Date:   Thu, 29 Dec 2022 02:32:22 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Michał Grzelak <mig@...ihalf.com>
Cc:     linux-kernel@...r.kernel.org, sebastian.hesselbarth@...il.com,
        gregory.clement@...tlin.com, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        mw@...ihalf.com, upstream@...ihalf.com, mchl.grzlk@...il.com
Subject: Re: [PATCH v2] ARM: dts: dove.dtsi: Move ethphy to fix schema error

On Wed, Dec 28, 2022 at 09:02:34PM +0100, Michał Grzelak wrote:
> Running 'make dtbs_check' with schema in net/marvell,orion-mdio.yaml
> gives the following warnings:
> mdio-bus@...04: Unevaluated properties are not allowed
> ('ethernet-phy' was unexpected)
> 	arch/arm/boot/dts/dove-cubox.dtb
> 	arch/arm/boot/dts/dove-cubox-es.dtb
> 	arch/arm/boot/dts/dove-d2plug.dtb
> 	arch/arm/boot/dts/dove-d2plug.dtb
> 	arch/arm/boot/dts/dove-dove-db.dtb
> 	arch/arm/boot/dts/dove-d3plug.dtb
> 	arch/arm/boot/dts/dove-sbc-a510.dtb
> Fix them by removing empty ethphy subnode from dove.dtsi and describe
> PHY on the relevant board .dts files level.

I don't think your description is correct. What i think is causing the
problem is that the ethphy subnode in dove.dtsi does not have an @X.

By moving it into the .dts file, you can then give it the correct @1,
or @3, which makes the linter happy. The kernel itself does not care
about this, it is an example of the linter being much more strict than
the kernel.

If you agree with me, please update the description.

   Andrew