linux-kernel - Re: [PATCH 01/14] drm/mipi-dsi: Add a mipi_dsi_dcs_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 29 Dec 2022 23:36:17 +0800
From:   kernel test robot <lkp@...el.com>
To:     Javier Martinez Canillas <javierm@...hat.com>,
        linux-kernel@...r.kernel.org
Cc:     oe-kbuild-all@...ts.linux.dev,
        Thomas Zimmermann <tzimmermann@...e.de>,
        Javier Martinez Canillas <javierm@...hat.com>,
        dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH 01/14] drm/mipi-dsi: Add a mipi_dsi_dcs_write_seq() macro

Hi Javier,

I love your patch! Perhaps something to improve:

[auto build test WARNING on drm-misc/drm-misc-next]
[also build test WARNING on linus/master v6.2-rc1 next-20221226]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Javier-Martinez-Canillas/drm-mipi-dsi-Add-a-mipi_dsi_dcs_write_seq-macro/20221228-100040
base:   git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
patch link:    https://lore.kernel.org/r/20221228014757.3170486-2-javierm%40redhat.com
patch subject: [PATCH 01/14] drm/mipi-dsi: Add a mipi_dsi_dcs_write_seq() macro
reproduce:
        # https://github.com/intel-lab-lkp/linux/commit/6dbe3eb57c38eaa1be1271fe9563406472377dc7
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Javier-Martinez-Canillas/drm-mipi-dsi-Add-a-mipi_dsi_dcs_write_seq-macro/20221228-100040
        git checkout 6dbe3eb57c38eaa1be1271fe9563406472377dc7
        make menuconfig
        # enable CONFIG_COMPILE_TEST, CONFIG_WARN_MISSING_DOCUMENTS, CONFIG_WARN_ABI_ERRORS
        make htmldocs

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> ./include/drm/drm_mipi_dsi.h:314: warning: expecting prototype for mipi_dsi_generic_write(). Prototype was for mipi_dsi_generic_write_seq() instead

vim +314 ./include/drm/drm_mipi_dsi.h

   271	
   272	ssize_t mipi_dsi_dcs_write_buffer(struct mipi_dsi_device *dsi,
   273					  const void *data, size_t len);
   274	ssize_t mipi_dsi_dcs_write(struct mipi_dsi_device *dsi, u8 cmd,
   275				   const void *data, size_t len);
   276	ssize_t mipi_dsi_dcs_read(struct mipi_dsi_device *dsi, u8 cmd, void *data,
   277				  size_t len);
   278	int mipi_dsi_dcs_nop(struct mipi_dsi_device *dsi);
   279	int mipi_dsi_dcs_soft_reset(struct mipi_dsi_device *dsi);
   280	int mipi_dsi_dcs_get_power_mode(struct mipi_dsi_device *dsi, u8 *mode);
   281	int mipi_dsi_dcs_get_pixel_format(struct mipi_dsi_device *dsi, u8 *format);
   282	int mipi_dsi_dcs_enter_sleep_mode(struct mipi_dsi_device *dsi);
   283	int mipi_dsi_dcs_exit_sleep_mode(struct mipi_dsi_device *dsi);
   284	int mipi_dsi_dcs_set_display_off(struct mipi_dsi_device *dsi);
   285	int mipi_dsi_dcs_set_display_on(struct mipi_dsi_device *dsi);
   286	int mipi_dsi_dcs_set_column_address(struct mipi_dsi_device *dsi, u16 start,
   287					    u16 end);
   288	int mipi_dsi_dcs_set_page_address(struct mipi_dsi_device *dsi, u16 start,
   289					  u16 end);
   290	int mipi_dsi_dcs_set_tear_off(struct mipi_dsi_device *dsi);
   291	int mipi_dsi_dcs_set_tear_on(struct mipi_dsi_device *dsi,
   292				     enum mipi_dsi_dcs_tear_mode mode);
   293	int mipi_dsi_dcs_set_pixel_format(struct mipi_dsi_device *dsi, u8 format);
   294	int mipi_dsi_dcs_set_tear_scanline(struct mipi_dsi_device *dsi, u16 scanline);
   295	int mipi_dsi_dcs_set_display_brightness(struct mipi_dsi_device *dsi,
   296						u16 brightness);
   297	int mipi_dsi_dcs_get_display_brightness(struct mipi_dsi_device *dsi,
   298						u16 *brightness);
   299	
   300	/**
   301	 * mipi_dsi_generic_write - transmit data using a generic write packet
   302	 * @dsi: DSI peripheral device
   303	 * @seq: buffer containing the payload
   304	 */
   305	#define mipi_dsi_generic_write_seq(dsi, seq...) do {				\
   306			static const u8 d[] = { seq };					\
   307			struct device *dev = &dsi->dev;	\
   308			int ret;						\
   309			ret = mipi_dsi_generic_write(dsi, d, ARRAY_SIZE(d));	\
   310			if (ret < 0) {						\
   311				dev_err_ratelimited(dev, "transmit data failed: %d\n", ret); \
   312				return ret;						\
   313			}						\
 > 314		} while (0)
   315	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (38870 bytes)