linux-kernel - Re: [PATCH] drm/bridge: sii902x: Allow reset line to be tied to a sleepy GPIO controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <354afea4-f909-8352-753d-0f2509d7165b@intel.com>
Date:   Fri, 30 Dec 2022 16:39:57 +0100
From:   Andrzej Hajda <andrzej.hajda@...el.com>
To:     Wadim Egorov <w.egorov@...tec.de>, upstream@...ts.phytec.de,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Cc:     daniel@...ll.ch, airlied@...il.com, jernej.skrabec@...il.com,
        jonas@...boo.se, Laurent.pinchart@...asonboard.com,
        robert.foss@...aro.org, neil.armstrong@...aro.org
Subject: Re: [PATCH] drm/bridge: sii902x: Allow reset line to be tied to a
 sleepy GPIO controller



On 28.12.2022 15:57, Wadim Egorov wrote:
> Switch to gpiod_set_value_cansleep() in sii902x_reset().
> This is relevant if the reset line is tied to a I2C GPIO
> controller.
>
> Signed-off-by: Wadim Egorov <w.egorov@...tec.de>
Reviewed-by: Andrzej Hajda <andrzej.hajda@...el.com>

Regards
Andrzej
> ---
>   drivers/gpu/drm/bridge/sii902x.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c
> index 878fb7d3732b..980611aec2f6 100644
> --- a/drivers/gpu/drm/bridge/sii902x.c
> +++ b/drivers/gpu/drm/bridge/sii902x.c
> @@ -240,12 +240,12 @@ static void sii902x_reset(struct sii902x *sii902x)
>   	if (!sii902x->reset_gpio)
>   		return;
>   
> -	gpiod_set_value(sii902x->reset_gpio, 1);
> +	gpiod_set_value_cansleep(sii902x->reset_gpio, 1);
>   
>   	/* The datasheet says treset-min = 100us. Make it 150us to be sure. */
>   	usleep_range(150, 200);
>   
> -	gpiod_set_value(sii902x->reset_gpio, 0);
> +	gpiod_set_value_cansleep(sii902x->reset_gpio, 0);
>   }
>   
>   static enum drm_connector_status sii902x_detect(struct sii902x *sii902x)