linux-kernel - Re: [PATCH] mfd: rk808: re-add rk808-clkout to RK818

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b6e06ab3-1e31-d547-29cc-38037891227f@tom-fitzhenry.me.uk>
Date:   Mon, 2 Jan 2023 22:15:00 +1100
From:   Tom Fitzhenry <tom@...-fitzhenry.me.uk>
To:     Javier Martinez Canillas <javierm@...hat.com>,
        Lee Jones <lee@...nel.org>,
        Neil Armstrong <neil.armstrong@...aro.org>
Cc:     Ondrej Jirman <megi@....cz>, Martijn Braam <martijn@...xit.nl>,
        linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: rk808: re-add rk808-clkout to RK818

On 30/12/22 05:27, Javier Martinez Canillas wrote:
> On 12/28/22 15:07, Tom Fitzhenry wrote:
>> Fixes RK818 (e.g. on Pinephone Pro) to register its clock, without which
>> dependent devices (e.g. wifi/BT, via sdio-wifi-pwrseq) fail to probe.
>>
>> This line was removed in commit 3633daacea2e
>> ("mfd: rk808: Permit having multiple PMIC instances"), but only from RK818.
>>
> 
> Maybe add a Fixes: 3633daacea2e ("mfd: rk808: Permit having multiple PMIC instances") ?

SGTM. I have added this to the v2 patch.

> The patch looks good to me.
> 
> Reviewed-by: Javier Martinez Canillas <javierm@...hat.com>

Thanks, I have added this to the v2 patch.