linux-kernel - Re: [PATCH] mfd: rk808: re-add rk808-clkout to RK818

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aef7295e-264c-4812-06f5-b8f7a8339ed9@tom-fitzhenry.me.uk>
Date:   Mon, 2 Jan 2023 22:13:41 +1100
From:   Tom Fitzhenry <tom@...-fitzhenry.me.uk>
To:     neil.armstrong@...aro.org, Lee Jones <lee@...nel.org>
Cc:     Ondrej Jirman <megi@....cz>,
        Javier Martinez Canillas <javierm@...hat.com>,
        Martijn Braam <martijn@...xit.nl>,
        linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: rk808: re-add rk808-clkout to RK818

On 2/1/23 21:06, Neil Armstrong wrote:
> On 28/12/2022 15:07, Tom Fitzhenry wrote:
>> Fixes RK818 (e.g. on Pinephone Pro) to register its clock, without which
>> dependent devices (e.g. wifi/BT, via sdio-wifi-pwrseq) fail to probe.
>>
>> This line was removed in commit 3633daacea2e
>> ("mfd: rk808: Permit having multiple PMIC instances"), but only from 
>> RK818.
>>
>> Signed-off-by: Tom Fitzhenry <tom@...-fitzhenry.me.uk>
>> ---
>>   drivers/mfd/rk808.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c
>> index f44fc3f080a8..0f22ef61e817 100644
>> --- a/drivers/mfd/rk808.c
>> +++ b/drivers/mfd/rk808.c
>> @@ -189,6 +189,7 @@ static const struct mfd_cell rk817s[] = {
>>   };
>>   static const struct mfd_cell rk818s[] = {
>> +    { .name = "rk808-clkout", .id = PLATFORM_DEVID_NONE, },
>>       { .name = "rk808-regulator", .id = PLATFORM_DEVID_NONE, },
>>       {
>>           .name = "rk808-rtc",
>>
>> base-commit: c76083fac3bae1a87ae3d005b5cb1cbc761e31d5
> 
> Sorry, my bad...

No worries!

> Acked-by: Neil Armstrong <neil.armstrong@...aro.org>

Thanks, I have added this to the v2 patch.