linux-kernel - Re: [PATCH printk v3 4/6] printk: introduce struct console

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y7LyHpHlLc3J+zXk@alley>
Date:   Mon, 2 Jan 2023 16:15:03 +0100
From:   Petr Mladek <pmladek@...e.com>
To:     John Ogness <john.ogness@...utronix.de>
Cc:     Sergey Senozhatsky <senozhatsky@...omium.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH printk v3 4/6] printk: introduce struct console_buffers

On Wed 2022-12-21 21:33:02, John Ogness wrote:
> Introduce a new struct console_buffers to contain all the buffers
> needed to read and format a printk message for console output.
> Putting the buffers inside a struct reduces the number of buffer
> pointers that need to be tracked. Also, it allows usage of the
> sizeof() macro for the buffer sizes, rather than expecting certain
> sized buffers being passed in.
> 
> Note that since the output buffer for normal consoles is now
> CONSOLE_EXT_LOG_MAX instead of CONSOLE_LOG_MAX, multi-line
> messages that may have been previously truncated will now be
> printed in full. This should be considered a feature and not a bug
> since the CONSOLE_LOG_MAX restriction was about limiting static
> buffer usage rather than limiting printed text.
> 
> Signed-off-by: John Ogness <john.ogness@...utronix.de>

Reviewed-by: Petr Mladek <pmladek@...e.com>

Thanks for renaming the buffers. I believe that it will make
the code easier to follow in the long term.

Best Regards,
Petr