linux-kernel - Re: [PATCH 1/2] brcmfmac: Use separate struct to declare firmware names for Apple OTP chips

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9c5bdb0a-0877-ed16-f09f-164a9dab16d4@marcan.st>
Date:   Tue, 3 Jan 2023 00:15:33 +0900
From:   Hector Martin <marcan@...can.st>
To:     Aditya Garg <gargaditya08@...e.com>,
        "aspriel@...il.com" <aspriel@...il.com>,
        "hante.meuleman@...adcom.com" <hante.meuleman@...adcom.com>,
        "kvalo@...nel.org" <kvalo@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "lina@...hilina.net" <lina@...hilina.net>,
        "franky.lin@...adcom.com" <franky.lin@...adcom.com>,
        Arend van Spriel <arend.vanspriel@...adcom.com>
Cc:     Orlando Chamberlain <redecorating@...tonmail.com>,
        "brcm80211-dev-list@...adcom.com" <brcm80211-dev-list@...adcom.com>,
        "brcm80211-dev-list.pdl@...adcom.com" 
        <brcm80211-dev-list.pdl@...adcom.com>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Asahi Linux <asahi@...ts.linux.dev>
Subject: Re: [PATCH 1/2] brcmfmac: Use separate struct to declare firmware
 names for Apple OTP chips

On 02/01/2023 23.40, Aditya Garg wrote:
> From: Aditya Garg <gargaditya08@...e.com>
> 
> Commit 'dce45ded7619' added support for 89459 chip pcie device. It uses the
> BRCM4355 chip which is also found in Apple hardware. However this commit
> causes conflicts in the firmware naming between Apple hardware, which
> supports OTP and other non-Apple hardwares. So, this patch makes these
> Apple chips use their own firmware table so as to avoid possible conflicts
> like these in the future.
> 

I think my reply to Arend flew over your head.

My point was that I'd rather have the Broadcom/Cypress people actually
answer my question so we can figure out how to do this *properly*,
instead of doing "safer-but-dumb" things (like this patch) because we
just don't have the information to do it properly.

- Hector