linux-kernel - Re: [PATCH RESEND v2 04/10] block, bfq: use helper macro RQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 2 Jan 2023 16:31:34 +0100
From:   Jan Kara <jack@...e.cz>
To:     Kemeng Shi <shikemeng@...weicloud.com>
Cc:     paolo.valente@...aro.org, axboe@...nel.dk,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        jack@...e.cz, hch@....de, damien.lemoal@....com
Subject: Re: [PATCH RESEND v2 04/10] block, bfq: use helper macro RQ_BFQQ to
 get bfqq of request

On Fri 23-12-22 03:16:35, Kemeng Shi wrote:
> Use helper macro RQ_BFQQ to get bfqq of request.
> 
> Signed-off-by: Kemeng Shi <shikemeng@...weicloud.com>

Yeah, why not. Feel free to add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  block/bfq-iosched.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c
> index 9441fc98961a..c3c4c83ee95f 100644
> --- a/block/bfq-iosched.c
> +++ b/block/bfq-iosched.c
> @@ -6683,14 +6683,14 @@ static struct bfq_queue *bfq_init_rq(struct request *rq)
>  		return NULL;
>  
>  	/*
> -	 * Assuming that elv.priv[1] is set only if everything is set
> +	 * Assuming that RQ_BFQQ(rq) is set only if everything is set
>  	 * for this rq. This holds true, because this function is
>  	 * invoked only for insertion or merging, and, after such
>  	 * events, a request cannot be manipulated any longer before
>  	 * being removed from bfq.
>  	 */
> -	if (rq->elv.priv[1])
> -		return rq->elv.priv[1];
> +	if (RQ_BFQQ(rq))
> +		return RQ_BFQQ(rq);
>  
>  	bic = icq_to_bic(rq->elv.icq);
>  
> -- 
> 2.30.0
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR