linux-kernel - Re: [PATCH 1/2] gpio: vf610: connect GPIO label to dev name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=MdW5OfHPy5hmJddV65C8-eqeQSt4dd_p=03jBNR65vrAg@mail.gmail.com>
Date:   Mon, 2 Jan 2023 09:03:45 +0100
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     haibo.chen@....com
Cc:     linus.walleij@...aro.org, stefan@...er.ch,
        linux-gpio@...r.kernel.org, linux-imx@....com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] gpio: vf610: connect GPIO label to dev name

On Tue, Dec 20, 2022 at 10:02 AM <haibo.chen@....com> wrote:
>
> From: Haibo Chen <haibo.chen@....com>
>
> Current GPIO label is fixed, so can't distinguish different GPIO
> controllers through labels. Use dev name instead.
>
> Fixes: 7f2691a19627 ("gpio: vf610: add gpiolib/IRQ chip driver for Vybrid")
> Signed-off-by: Clark Wang <xiaoning.wang@....com>
> Signed-off-by: Haibo Chen <haibo.chen@....com>
> ---
>  drivers/gpio/gpio-vf610.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-vf610.c b/drivers/gpio/gpio-vf610.c
> index 9db42f6a2043..a429176673e7 100644
> --- a/drivers/gpio/gpio-vf610.c
> +++ b/drivers/gpio/gpio-vf610.c
> @@ -304,7 +304,7 @@ static int vf610_gpio_probe(struct platform_device *pdev)
>
>         gc = &port->gc;
>         gc->parent = dev;
> -       gc->label = "vf610-gpio";
> +       gc->label = dev_name(dev);
>         gc->ngpio = VF610_GPIO_PER_PORT;
>         gc->base = of_alias_get_id(np, "gpio") * VF610_GPIO_PER_PORT;
>
> --
> 2.34.1
>

I applied this one, please fix patch 2/2 and resend on its own.

Bartosz