linux-kernel - Re: [PATCH v1] drivers/fsl_linflexuart.c : remove redundant uart type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1c33a2af-cd0d-cdde-5bc7-49b418665784@kernel.org>
Date:   Tue, 3 Jan 2023 12:23:10 +0100
From:   Jiri Slaby <jirislaby@...nel.org>
To:     lizhe <sensor1010@....com>, gregkh@...uxfoundation.org
Cc:     linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] drivers/fsl_linflexuart.c : remove redundant uart type

On 03. 01. 23, 12:02, lizhe wrote:
> 	in linflex_config_port() the member variable will be
> 	assigned again . see linflex_config_port()

Fine, but can you make the subject and the commit message a little bit 
saner?

I.e. no tabs, no spaces before semicolons and colons. The subject should 
be something like "serial: linflexuart: remove redundant uart type 
_assignment_" and so on.

> Signed-off-by: lizhe <sensor1010@....com>

Is this your legal name?

> ---
>   drivers/tty/serial/fsl_linflexuart.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/fsl_linflexuart.c b/drivers/tty/serial/fsl_linflexuart.c
> index 6fc21b6684e6..34400cc6ac7f 100644
> --- a/drivers/tty/serial/fsl_linflexuart.c
> +++ b/drivers/tty/serial/fsl_linflexuart.c
> @@ -837,7 +837,6 @@ static int linflex_probe(struct platform_device *pdev)
>   		return PTR_ERR(sport->membase);
>   
>   	sport->dev = &pdev->dev;
> -	sport->type = PORT_LINFLEXUART;
>   	sport->iotype = UPIO_MEM;
>   	sport->irq = platform_get_irq(pdev, 0);
>   	sport->ops = &linflex_pops;

-- 
js
suse labs