linux-kernel - [PATCH net-next v2] fjes: Fix an error handling path in fjes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <a294f5f3af7e29212a27cc7d17503fba346266b5.1672864635.git.christophe.jaillet@wanadoo.fr>
Date:   Wed,  4 Jan 2023 21:40:47 +0100
From:   Christophe JAILLET <christophe.jaillet@...adoo.fr>
To:     Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>,
        Taku Izumi <izumi.taku@...fujitsu.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        netdev@...r.kernel.org
Subject: [PATCH net-next v2] fjes: Fix an error handling path in fjes_probe()

free_netdev() already calls netif_napi_del(), no need to call it
explicitly.
It's harmless, but useless.

Remove the call, make the  error handling path of the probe and the remove
function be consistent one with the other.

Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
---
Change in v2:
  - Leave the error handling path of the probe as-is, and simplify the
    remove function instead.
  - Removes the Fixes tag. It's finally not at fix, just a consistency
    issue. (was Fixes: 265859309a76 ("fjes: NAPI polling function"))
  - As a consequence, target net-next instead of net, now.

v1:
https://lore.kernel.org/all/fde673f106d2b264ad76759195901aae94691b5c.1671569785.git.christophe.jaillet@wanadoo.fr/
---
 drivers/net/fjes/fjes_main.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/fjes/fjes_main.c b/drivers/net/fjes/fjes_main.c
index 5805e4a56385..db9c0da82f33 100644
--- a/drivers/net/fjes/fjes_main.c
+++ b/drivers/net/fjes/fjes_main.c
@@ -1324,8 +1324,6 @@ static int fjes_remove(struct platform_device *plat_dev)
 
 	fjes_hw_exit(hw);
 
-	netif_napi_del(&adapter->napi);
-
 	free_netdev(netdev);
 
 	return 0;
-- 
2.34.1