linux-kernel - Re: [PATCH net-next v2] fjes: Fix an error handling path in fjes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y7bap08pgqs1LL48@nanopsycho>
Date:   Thu, 5 Jan 2023 15:11:51 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>,
        Taku Izumi <izumi.taku@...fujitsu.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2] fjes: Fix an error handling path in
 fjes_probe()

Wed, Jan 04, 2023 at 09:40:47PM CET, christophe.jaillet@...adoo.fr wrote:
>free_netdev() already calls netif_napi_del(), no need to call it
>explicitly.
>It's harmless, but useless.
>
>Remove the call, make the  error handling path of the probe and the remove
>function be consistent one with the other.
>
>Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Reviewed-by: Jiri Pirko <jiri@...dia.com>