linux-kernel - Re: [PATCH v2 3/7] powerpc/secvar: Use sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f3081bfd9bb08914797186382bf5c9cd5140d2ad.camel@linux.ibm.com>
Date:   Wed, 04 Jan 2023 18:12:28 +1100
From:   Andrew Donnellan <ajd@...ux.ibm.com>
To:     Russell Currey <ruscur@...sell.cc>, linuxppc-dev@...ts.ozlabs.org
Cc:     gregkh@...uxfoundation.org, gcwilson@...ux.ibm.com,
        linux-kernel@...r.kernel.org, nayna@...ux.ibm.com,
        zohar@...ux.ibm.com, mpe@...erman.id.au
Subject: Re: [PATCH v2 3/7] powerpc/secvar: Use sysfs_emit() instead of
 sprintf()

On Fri, 2022-12-30 at 15:20 +1100, Russell Currey wrote:
> The secvar format string and object size sysfs files are both ASCII
> text, and should use sysfs_emit().  No functional change.
> 
> Suggested-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Signed-off-by: Russell Currey <ruscur@...sell.cc>

LGTM

Reviewed-by: Andrew Donnellan <ajd@...ux.ibm.com>

> ---
> v2: new
> 
>  arch/powerpc/kernel/secvar-sysfs.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/powerpc/kernel/secvar-sysfs.c
> b/arch/powerpc/kernel/secvar-sysfs.c
> index 1ee4640a2641..02e9fee1552e 100644
> --- a/arch/powerpc/kernel/secvar-sysfs.c
> +++ b/arch/powerpc/kernel/secvar-sysfs.c
> @@ -35,7 +35,7 @@ static ssize_t format_show(struct kobject *kobj,
> struct kobj_attribute *attr,
>         if (rc)
>                 goto out;
>  
> -       rc = sprintf(buf, "%s\n", format);
> +       rc = sysfs_emit(buf, "%s\n", format);
>  
>  out:
>         of_node_put(node);
> @@ -57,7 +57,7 @@ static ssize_t size_show(struct kobject *kobj,
> struct kobj_attribute *attr,
>                 return rc;
>         }
>  
> -       return sprintf(buf, "%llu\n", dsize);
> +       return sysfs_emit(buf, "%llu\n", dsize);
>  }
>  
>  static ssize_t data_read(struct file *filep, struct kobject *kobj,

-- 
Andrew Donnellan    OzLabs, ADL Canberra
ajd@...ux.ibm.com   IBM Australia Limited