| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20230104112144.n2mx33xqavigxwa2@blmsp>
Date: Wed, 4 Jan 2023 12:21:44 +0100
From: Markus Schneider-Pargmann <msp@...libre.com>
To: AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>
Cc: mturquette@...libre.com, sboyd@...nel.org, matthias.bgg@...il.com,
robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
wenst@...omium.org, johnson.wang@...iatek.com,
miles.chen@...iatek.com, fparent@...libre.com,
chun-jie.chen@...iatek.com, sam.shih@...iatek.com,
y.oudjana@...tonmail.com, nfraprado@...labora.com,
rex-bc.chen@...iatek.com, ryder.lee@...nel.org,
daniel@...rotopia.org, jose.exposito89@...il.com,
yangyingliang@...wei.com, pablo.sun@...iatek.com,
weiyi.lu@...iatek.com, ikjn@...omium.org,
linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org, devicetree@...r.kernel.org,
kernel@...labora.com
Subject: Re: [PATCH v2 03/23] clk: mediatek: clk-gate: Propagate struct
device with mtk_clk_register_gates()
Hi Angelo,
On Fri, Dec 23, 2022 at 10:42:39AM +0100, AngeloGioacchino Del Regno wrote:
> Commit e4c23e19aa2a ("clk: mediatek: Register clock gate with device")
> introduces a helper function for the sole purpose of propagating a
> struct device pointer to the clk API when registering the mtk-gate
> clocks to take advantage of Runtime PM when/where needed and where
> a power domain is defined in devicetree.
>
> Function mtk_clk_register_gates() then becomes a wrapper around the
> new mtk_clk_register_gates_with_dev() function that will simply pass
> NULL as struct device: this is essential when registering drivers
> with CLK_OF_DECLARE instead of as a platform device, as there will
> be no struct device to pass... but we can as well simply have only
> one function that always takes such pointer as a param and pass NULL
> when unavoidable.
>
> This commit removes the mtk_clk_register_gates() wrapper and renames
> mtk_clk_register_gates_with_dev() to the former and all of the calls
> to either of the two functions were fixed in all drivers in order to
> reflect this change.
>
> Since a lot of MediaTek clock drivers are actually registering as a
> platform device, but were still registering the mtk-gate clocks
> without passing any struct device to the clock framework, they've
> been changed to pass a valid one now, as to make all those platforms
> able to use runtime power management where available.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
A few nitpicks, otherwise it looks good,
Reviewed-by: Markus Schneider-Pargmann <msp@...libre.com>
> ---
> drivers/clk/mediatek/clk-gate.c | 16 ++++------------
> drivers/clk/mediatek/clk-gate.h | 8 ++------
> drivers/clk/mediatek/clk-mt2701-aud.c | 2 +-
> drivers/clk/mediatek/clk-mt2701-eth.c | 2 +-
> drivers/clk/mediatek/clk-mt2701-g3d.c | 2 +-
> drivers/clk/mediatek/clk-mt2701-hif.c | 2 +-
> drivers/clk/mediatek/clk-mt2701-mm.c | 2 +-
> drivers/clk/mediatek/clk-mt2701.c | 6 +++---
> drivers/clk/mediatek/clk-mt2712-mm.c | 2 +-
> drivers/clk/mediatek/clk-mt2712.c | 6 +++---
> drivers/clk/mediatek/clk-mt6765.c | 6 +++---
> drivers/clk/mediatek/clk-mt6779-mm.c | 2 +-
> drivers/clk/mediatek/clk-mt6779.c | 4 ++--
> drivers/clk/mediatek/clk-mt6795-infracfg.c | 3 ++-
> drivers/clk/mediatek/clk-mt6795-mm.c | 3 ++-
> drivers/clk/mediatek/clk-mt6795-pericfg.c | 3 ++-
> drivers/clk/mediatek/clk-mt6797-mm.c | 2 +-
> drivers/clk/mediatek/clk-mt6797.c | 2 +-
> drivers/clk/mediatek/clk-mt7622-aud.c | 2 +-
> drivers/clk/mediatek/clk-mt7622-eth.c | 4 ++--
> drivers/clk/mediatek/clk-mt7622-hif.c | 4 ++--
> drivers/clk/mediatek/clk-mt7622.c | 9 +++++----
> drivers/clk/mediatek/clk-mt7629-eth.c | 5 +++--
> drivers/clk/mediatek/clk-mt7629-hif.c | 4 ++--
> drivers/clk/mediatek/clk-mt7629.c | 6 +++---
> drivers/clk/mediatek/clk-mt7986-eth.c | 6 +++---
> drivers/clk/mediatek/clk-mt7986-infracfg.c | 2 +-
> drivers/clk/mediatek/clk-mt8135.c | 4 ++--
> drivers/clk/mediatek/clk-mt8167-aud.c | 2 +-
> drivers/clk/mediatek/clk-mt8167-img.c | 2 +-
> drivers/clk/mediatek/clk-mt8167-mfgcfg.c | 2 +-
> drivers/clk/mediatek/clk-mt8167-mm.c | 2 +-
> drivers/clk/mediatek/clk-mt8167-vdec.c | 3 ++-
> drivers/clk/mediatek/clk-mt8167.c | 2 +-
> drivers/clk/mediatek/clk-mt8173-mm.c | 2 +-
> drivers/clk/mediatek/clk-mt8173.c | 12 ++++++------
> drivers/clk/mediatek/clk-mt8183-audio.c | 2 +-
> drivers/clk/mediatek/clk-mt8183-mm.c | 2 +-
> drivers/clk/mediatek/clk-mt8183.c | 8 ++++----
> drivers/clk/mediatek/clk-mt8186-mm.c | 3 ++-
> drivers/clk/mediatek/clk-mt8192-aud.c | 3 ++-
> drivers/clk/mediatek/clk-mt8192-mm.c | 3 ++-
> drivers/clk/mediatek/clk-mt8192.c | 12 ++++++------
> drivers/clk/mediatek/clk-mt8195-apmixedsys.c | 3 ++-
> drivers/clk/mediatek/clk-mt8195-topckgen.c | 3 ++-
> drivers/clk/mediatek/clk-mt8195-vdo0.c | 3 ++-
> drivers/clk/mediatek/clk-mt8195-vdo1.c | 3 ++-
> drivers/clk/mediatek/clk-mt8365-mm.c | 5 ++---
> drivers/clk/mediatek/clk-mt8365.c | 2 +-
> drivers/clk/mediatek/clk-mt8516-aud.c | 2 +-
> drivers/clk/mediatek/clk-mt8516.c | 2 +-
> drivers/clk/mediatek/clk-mtk.c | 4 ++--
> 52 files changed, 103 insertions(+), 103 deletions(-)
>
[...]
> diff --git a/drivers/clk/mediatek/clk-mt7986-eth.c b/drivers/clk/mediatek/clk-mt7986-eth.c
> index 7868c0728e96..765df117afa6 100644
> --- a/drivers/clk/mediatek/clk-mt7986-eth.c
> +++ b/drivers/clk/mediatek/clk-mt7986-eth.c
> @@ -85,7 +85,7 @@ static void __init mtk_sgmiisys_0_init(struct device_node *node)
> clk_data = mtk_alloc_clk_data(ARRAY_SIZE(sgmii0_clks));
>
> mtk_clk_register_gates(node, sgmii0_clks, ARRAY_SIZE(sgmii0_clks),
> - clk_data);
> + clk_data, NULL);
>
> r = of_clk_add_hw_provider(node, of_clk_hw_onecell_get, clk_data);
> if (r)
> @@ -103,7 +103,7 @@ static void __init mtk_sgmiisys_1_init(struct device_node *node)
> clk_data = mtk_alloc_clk_data(ARRAY_SIZE(sgmii1_clks));
>
> mtk_clk_register_gates(node, sgmii1_clks, ARRAY_SIZE(sgmii1_clks),
> - clk_data);
> + clk_data, NULL);
>
> r = of_clk_add_hw_provider(node, of_clk_hw_onecell_get, clk_data);
>
> @@ -121,7 +121,7 @@ static void __init mtk_ethsys_init(struct device_node *node)
>
> clk_data = mtk_alloc_clk_data(ARRAY_SIZE(eth_clks));
>
> - mtk_clk_register_gates(node, eth_clks, ARRAY_SIZE(eth_clks), clk_data);
> + mtk_clk_register_gates(node, eth_clks, ARRAY_SIZE(eth_clks), clk_data, NULL);
You kept within 80c nearly everywhere, but there are a few calls where
you added 'NULL' that go over the 80c now. Not sure if that was
intended?!
>
> r = of_clk_add_hw_provider(node, of_clk_hw_onecell_get, clk_data);
>
[...]
> diff --git a/drivers/clk/mediatek/clk-mt8183-mm.c b/drivers/clk/mediatek/clk-mt8183-mm.c
> index 11ecc6fb0065..f93043da26c0 100644
> --- a/drivers/clk/mediatek/clk-mt8183-mm.c
> +++ b/drivers/clk/mediatek/clk-mt8183-mm.c
> @@ -91,7 +91,7 @@ static int clk_mt8183_mm_probe(struct platform_device *pdev)
> clk_data = mtk_alloc_clk_data(CLK_MM_NR_CLK);
>
> mtk_clk_register_gates(node, mm_clks, ARRAY_SIZE(mm_clks),
> - clk_data);
> + clk_data, &pdev->dev);
This is not aligned with the opening bracket here and a few below. Maybe
you can fix it with your patch as well.
>
> return of_clk_add_hw_provider(node, of_clk_hw_onecell_get, clk_data);
> }
[...]
> diff --git a/drivers/clk/mediatek/clk-mt8192.c b/drivers/clk/mediatek/clk-mt8192.c
> index 991d78a71644..e1b625b86911 100644
> --- a/drivers/clk/mediatek/clk-mt8192.c
> +++ b/drivers/clk/mediatek/clk-mt8192.c
> @@ -1127,7 +1127,7 @@ static int clk_mt8192_top_probe(struct platform_device *pdev)
> if (r)
> goto unregister_top_composites;
>
> - r = mtk_clk_register_gates_with_dev(node, top_clks, ARRAY_SIZE(top_clks),
> + r = mtk_clk_register_gates(node, top_clks, ARRAY_SIZE(top_clks),
> top_clk_data, &pdev->dev);
Here and below, the function call got shorter, please fix the
indentation in the following lines.
Best,
Markus
Powered by blists - more mailing lists