linux-kernel - Re: [PATCH v6 25/45] drm/amd: Use `amdgpu_ucode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <96d3a15e-cc34-50d4-93b3-5d5c59e6f40d@amd.com>
Date:   Thu, 5 Jan 2023 12:17:55 -0500
From:   Harry Wentland <harry.wentland@....com>
To:     Mario Limonciello <mario.limonciello@....com>,
        Alex Deucher <alexander.deucher@....com>,
        linux-kernel@...r.kernel.org
Cc:     Javier Martinez Canillas <javierm@...hat.com>,
        Carlos Soriano Sanchez <csoriano@...hat.com>,
        amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>, christian.koenig@....com,
        Lazar Lijo <Lijo.Lazar@....com>, Leo Li <sunpeng.li@....com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@....com>,
        "Pan, Xinhui" <Xinhui.Pan@....com>
Subject: Re: [PATCH v6 25/45] drm/amd: Use `amdgpu_ucode_release` helper for
 DMUB

On 1/4/23 22:42, Mario Limonciello wrote:
> The `amdgpu_ucode_release` helper is for symmetry on unloading.
> 
> Reviewed-by: Alex Deucher <alexander.deucher@....com>
> Signed-off-by: Mario Limonciello <mario.limonciello@....com>

Reviewed-by: Harry Wentland <harry.wentland@....com>

Harry

> ---
> v5->v6:
>  * Adjust for amdgpu_ucode_release argument change
> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index c8c5d37c8b3a..61c192ead62f 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -1898,8 +1898,7 @@ static int load_dmcu_fw(struct amdgpu_device *adev)
>  	if (r) {
>  		dev_err(adev->dev, "amdgpu_dm: Can't validate firmware \"%s\"\n",
>  			fw_name_dmcu);
> -		release_firmware(adev->dm.fw_dmcu);
> -		adev->dm.fw_dmcu = NULL;
> +		amdgpu_ucode_release(&adev->dm.fw_dmcu);
>  		return r;
>  	}
>  
> @@ -2113,11 +2112,8 @@ static int dm_sw_fini(void *handle)
>  		adev->dm.dmub_srv = NULL;
>  	}
>  
> -	release_firmware(adev->dm.dmub_fw);
> -	adev->dm.dmub_fw = NULL;
> -
> -	release_firmware(adev->dm.fw_dmcu);
> -	adev->dm.fw_dmcu = NULL;
> +	amdgpu_ucode_release(&adev->dm.dmub_fw);
> +	amdgpu_ucode_release(&adev->dm.fw_dmcu);
>  
>  	return 0;
>  }