linux-kernel - Re: [PATCH v6 42/45] drm/amd: Use `amdgpu_ucode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6c1264f7-3165-d23d-0c4e-d8b992d054c3@amd.com>
Date:   Thu, 5 Jan 2023 12:18:44 -0500
From:   Harry Wentland <harry.wentland@....com>
To:     Mario Limonciello <mario.limonciello@....com>,
        Alex Deucher <alexander.deucher@....com>,
        linux-kernel@...r.kernel.org
Cc:     Javier Martinez Canillas <javierm@...hat.com>,
        Carlos Soriano Sanchez <csoriano@...hat.com>,
        amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>, christian.koenig@....com,
        Lazar Lijo <Lijo.Lazar@....com>, Leo Li <sunpeng.li@....com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@....com>,
        "Pan, Xinhui" <Xinhui.Pan@....com>
Subject: Re: [PATCH v6 42/45] drm/amd: Use `amdgpu_ucode_*` helpers for DMCU



On 1/4/23 22:43, Mario Limonciello wrote:
> The `amdgpu_ucode_request` helper will ensure that the return code for
> missing firmware is -ENODEV so that early_init can fail.
> 
> The `amdgpu_ucode_release` helper is for symmetry on unloading.
> 
> Reviewed-by: Alex Deucher <alexander.deucher@....com>
> Signed-off-by: Mario Limonciello <mario.limonciello@....com>

Reviewed-by: Harry Wentland <harry.wentland@....com>

Harry

> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 11 ++---------
>  1 file changed, 2 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 61c192ead62f..79c4652e8e40 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -1881,20 +1881,13 @@ static int load_dmcu_fw(struct amdgpu_device *adev)
>  		return 0;
>  	}
>  
> -	r = request_firmware_direct(&adev->dm.fw_dmcu, fw_name_dmcu, adev->dev);
> -	if (r == -ENOENT) {
> +	r = amdgpu_ucode_request(adev, &adev->dm.fw_dmcu, fw_name_dmcu);
> +	if (r == -ENODEV) {
>  		/* DMCU firmware is not necessary, so don't raise a fuss if it's missing */
>  		DRM_DEBUG_KMS("dm: DMCU firmware not found\n");
>  		adev->dm.fw_dmcu = NULL;
>  		return 0;
>  	}
> -	if (r) {
> -		dev_err(adev->dev, "amdgpu_dm: Can't load firmware \"%s\"\n",
> -			fw_name_dmcu);
> -		return r;
> -	}
> -
> -	r = amdgpu_ucode_validate(adev->dm.fw_dmcu);
>  	if (r) {
>  		dev_err(adev->dev, "amdgpu_dm: Can't validate firmware \"%s\"\n",
>  			fw_name_dmcu);