linux-kernel - [PATCH] filesystems: Simplify if conditional statements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20230105061831.3516-1-zeming@nfschina.com>
Date:   Thu,  5 Jan 2023 14:18:31 +0800
From:   Li zeming <zeming@...china.com>
To:     viro@...iv.linux.org.uk
Cc:     linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        Li zeming <zeming@...china.com>
Subject: [PATCH] filesystems: Simplify if conditional statements

When the * p pointer is null, assign a value to res; otherwise, do not
execute the content in the conditional statement block.

Signed-off-by: Li zeming <zeming@...china.com>
---
 fs/filesystems.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/fs/filesystems.c b/fs/filesystems.c
index 58b9067b2391..1839dcd6cfbd 100644
--- a/fs/filesystems.c
+++ b/fs/filesystems.c
@@ -71,7 +71,7 @@ static struct file_system_type **find_filesystem(const char *name, unsigned len)
  
 int register_filesystem(struct file_system_type * fs)
 {
-	int res = 0;
+	int res = -EBUSY;
 	struct file_system_type ** p;
 
 	if (fs->parameters &&
@@ -83,10 +83,10 @@ int register_filesystem(struct file_system_type * fs)
 		return -EBUSY;
 	write_lock(&file_systems_lock);
 	p = find_filesystem(fs->name, strlen(fs->name));
-	if (*p)
-		res = -EBUSY;
-	else
+	if (!*p) {
+		res = 0;
 		*p = fs;
+	}
 	write_unlock(&file_systems_lock);
 	return res;
 }
-- 
2.18.2