linux-kernel - Re: [PATCH 3/7] nvmet: introduce bdev_zone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1484d284-e55e-4e3d-b4fc-5a685002c656@acm.org>
Date:   Fri, 6 Jan 2023 14:39:36 -0800
From:   Bart Van Assche <bvanassche@....org>
To:     Pankaj Raghav <p.raghav@...sung.com>, axboe@...nel.dk
Cc:     kernel@...kajraghav.com, linux-kernel@...r.kernel.org,
        hare@...e.de, snitzer@...nel.org, dm-devel@...hat.com,
        damien.lemoal@...nsource.wdc.com, linux-nvme@...ts.infradead.org,
        hch@....de, linux-block@...r.kernel.org, gost.dev@...sung.com
Subject: Re: [PATCH 3/7] nvmet: introduce bdev_zone_no helper

On 1/6/23 00:33, Pankaj Raghav wrote:
> A generic bdev_zone_no() helper is added to calculate zone number for a
> given sector in a block device. This helper internally uses disk_zone_no()
> to find the zone number.
> 
> Use the helper bdev_zone_no() to calculate nr of zones. This let's us
> make modifications to the math if needed in one place.

Please use the imperative mood in patch descriptions (... is added -> 
add ...).

let's -> lets

If these two issues are addressed, please add:

Reviewed-by: Bart Van Assche <bvanassche@....org>