linux-kernel - Re: [PATCH v6 net-next 1/2] net: phy: micrel: Fixed error related to uninitialized symbol ret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 6 Jan 2023 09:17:09 +0000
From:   <Arun.Ramadoss@...rochip.com>
To:     <andrew@...n.ch>, <linux-kernel@...r.kernel.org>,
        <linux@...linux.org.uk>, <Divya.Koppera@...rochip.com>,
        <kuba@...nel.org>, <edumazet@...gle.com>, <pabeni@...hat.com>,
        <richardcochran@...il.com>, <netdev@...r.kernel.org>,
        <alexanderduyck@...com>, <davem@...emloft.net>,
        <hkallweit1@...il.com>
CC:     <UNGLinuxDriver@...rochip.com>
Subject: Re: [PATCH v6 net-next 1/2] net: phy: micrel: Fixed error related to
 uninitialized symbol ret

Hi Divya,

On Fri, 2023-01-06 at 13:59 +0530, Divya Koppera wrote:
> Initialized return variable
> 
> Fixes Old smatch warnings:
> drivers/net/phy/micrel.c:1750 ksz886x_cable_test_get_status() error:
> uninitialized symbol 'ret'.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> Signed-off-by: Divya Koppera <Divya.Koppera@...rochip.com>

I think, Reviewed-by tag should come after signed-off tag. It should be
in chronological order.