linux-kernel - Re: [PATCH] kbuild: rust: move rust/target.json to scripts/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNARKUX9S3K0TiQuRnnYB=WwQMuYjygGwyGMBYWwW5UbtQQ@mail.gmail.com>
Date:   Sat, 7 Jan 2023 18:43:15 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc:     linux-kbuild@...r.kernel.org, Miguel Ojeda <ojeda@...nel.org>,
        rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org,
        Alex Gaynor <alex.gaynor@...il.com>,
        Wedson Almeida Filho <wedsonaf@...il.com>,
        Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
        Björn Roy Baron <bjorn3_gh@...tonmail.com>,
        Borislav Petkov <bp@...e.de>, David Gow <davidgow@...gle.com>,
        Helge Deller <deller@....de>,
        Kees Cook <keescook@...omium.org>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Nicolas Schier <nicolas@...sle.eu>,
        Palmer Dabbelt <palmer@...osinc.com>,
        Segher Boessenkool <segher@...nel.crashing.org>
Subject: Re: [PATCH] kbuild: rust: move rust/target.json to scripts/

On Sun, Jan 1, 2023 at 12:08 AM Miguel Ojeda
<miguel.ojeda.sandonis@...il.com> wrote:
>
> On Sat, Dec 31, 2022 at 3:57 PM Masahiro Yamada <masahiroy@...nel.org> wrote:
> >
> > No.
> > scripts/target.json is a generated file.
> > It is generated in objtree, not in srctree.
>
> I meant `$(objtree)`, i.e. I meant if we should use a $(...)` prefix
> for clarity/consistency (even if it is just `.`).


I usually do not add $(objtree)/.


include/config/auto.conf is also a generated file.

It is inconsistent to add $(objtree)/
to scripts/generate_rust_target,
but not to include/config/auto.conf.



(obj)/target.json: $(objtree)/scripts/generate_rust_target
$(objtree)/include/config/auto.conf FORCE
          $(call filechk,rust_target)

is annoying.



-- 
Best Regards
Masahiro Yamada