linux-kernel - Re: [PATCH] kbuild: rust: move rust/target.json to scripts/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANiq72nUuqqiRmLmmzAeZgK1D6kZJb9XLKAza02SzyPT=xgzZQ@mail.gmail.com>
Date:   Sat, 7 Jan 2023 15:45:17 +0100
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     Masahiro Yamada <masahiroy@...nel.org>
Cc:     linux-kbuild@...r.kernel.org, Miguel Ojeda <ojeda@...nel.org>,
        rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org,
        Alex Gaynor <alex.gaynor@...il.com>,
        Wedson Almeida Filho <wedsonaf@...il.com>,
        Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
        Björn Roy Baron <bjorn3_gh@...tonmail.com>,
        Borislav Petkov <bp@...e.de>, David Gow <davidgow@...gle.com>,
        Helge Deller <deller@....de>,
        Kees Cook <keescook@...omium.org>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Nicolas Schier <nicolas@...sle.eu>,
        Palmer Dabbelt <palmer@...osinc.com>,
        Segher Boessenkool <segher@...nel.crashing.org>
Subject: Re: [PATCH] kbuild: rust: move rust/target.json to scripts/

On Sat, Jan 7, 2023 at 10:43 AM Masahiro Yamada <masahiroy@...nel.org> wrote:
>
> I usually do not add $(objtree)/.
>
> include/config/auto.conf is also a generated file.
>
> It is inconsistent to add $(objtree)/
> to scripts/generate_rust_target,
> but not to include/config/auto.conf.
>
> (obj)/target.json: $(objtree)/scripts/generate_rust_target
> $(objtree)/include/config/auto.conf FORCE
>           $(call filechk,rust_target)
>
> is annoying.

Being consistent sounds good to me, and I agree there are already a
lot of `$`s around in `Makefile`s... :)

In general, I tend to prefer explicit over implicit -- it would make
non-prefixed paths less ambiguous on whether they are relative or
anchored to the root. And I guess it could help reduce confusion, e.g.
`arch/powerpc/boot/Makefile` mentions:

    # clean-files are relative to $(obj).

Either way, it is fine. Thanks a lot for explaining the logic! I just
sent a quick patch for Kbuild docs since I noticed it was outdated
regarding `objtree` for `clean-files`.

Cheers,
Miguel