linux-kernel - Re: [PATCH] dt-bindings: phy: qcom,qusb2: do not define properties in "if" block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <167320112477.148208.15939584193406100216.robh@kernel.org>
Date:   Sun, 8 Jan 2023 12:05:25 -0600
From:   Rob Herring <robh@...nel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Rob Herring <robh+dt@...nel.org>, Vinod Koul <vkoul@...nel.org>,
        devicetree@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-phy@...ts.infradead.org,
        Bjorn Andersson <andersson@...nel.org>,
        Andy Gross <agross@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        linux-kernel@...r.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Wesley Cheng <quic_wcheng@...cinc.com>,
        Kishon Vijay Abraham I <kishon@...nel.org>
Subject: Re: [PATCH] dt-bindings: phy: qcom,qusb2: do not define properties
 in "if" block


On Sat, 24 Dec 2022 16:42:26 +0100, Krzysztof Kozlowski wrote:
> It is more readable to define properties in top-level "properties:" and
> restrict them (if needed) per compatible in the "if" block.  Defining
> properties in "if" block  does not work correctly with
> additionalProperties:false:
> 
>   sc7180-trogdor-pazquel-lte-ti.dtb: phy@...3000: 'qcom,bias-ctrl-value', 'qcom,charge-ctrl-value', 'qcom,hsdisc-trim-value',
>     'qcom,imp-res-offset-value', 'qcom,preemphasis-level', 'qcom,preemphasis-width' do not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>  .../bindings/phy/qcom,qusb2-phy.yaml          | 160 ++++++++++--------
>  1 file changed, 85 insertions(+), 75 deletions(-)
> 

Acked-by: Rob Herring <robh@...nel.org>