linux-kernel - Re: [PATCH] drivers/media/v4l2-core/v4l2-h264 : add detection of null pointers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8b408632218fd0f06ec862a51822cf08e0f50a57.camel@collabora.com>
Date:   Mon, 09 Jan 2023 16:27:29 -0500
From:   Nicolas Dufresne <nicolas.dufresne@...labora.com>
To:     Dong Chuanjian <chuanjian@...china.com>, mchehab@...nel.org,
        hverkuil-cisco@...all.nl, sebastian.fricke@...labora.com,
        ezequiel@...guardiasur.com.ar
Cc:     linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/media/v4l2-core/v4l2-h264 : add detection of
 null pointers

Le mardi 27 décembre 2022 à 10:36 +0800, Dong Chuanjian a écrit :
> When the pointer variable is judged to be null, null is returned
> directly.
> 
> Signed-off-by: Dong Chuanjian <chuanjian@...china.com>

Acked-by: Nicolas Dufresne <nicolas.dufresne@...labora.com>

Please add the missing Fixes tag.

Fixes: d3f756ad629b39 ("media: v4l2: Trace calculated p/b0/b1 initial reflist")

If someone have time, the pr_debug should be ported to v4l2_debug according to
some other reviews.

> ---
> v2: Directly return when pointer allocation fails.
> v3: problems in synchronous repair format_ref_list_p
> 
> diff --git a/drivers/media/v4l2-core/v4l2-h264.c b/drivers/media/v4l2-core/v4l2-h264.c
> index 72bd64f65198..f6684c1d7319 100644
> --- a/drivers/media/v4l2-core/v4l2-h264.c
> +++ b/drivers/media/v4l2-core/v4l2-h264.c
> @@ -305,6 +305,8 @@ static const char *format_ref_list_p(const struct v4l2_h264_reflist_builder *bui
>  	int n = 0, i;
>  
>  	*out_str = kmalloc(tmp_str_size, GFP_KERNEL);
> +	if (*out_str == NULL)
> +		return NULL;
>  
>  	n += snprintf(*out_str + n, tmp_str_size - n, "|");
>  
> @@ -343,6 +345,8 @@ static const char *format_ref_list_b(const struct v4l2_h264_reflist_builder *bui
>  	int n = 0, i;
>  
>  	*out_str = kmalloc(tmp_str_size, GFP_KERNEL);
> +	if (*out_str == NULL)
> +		return NULL;
>  
>  	n += snprintf(*out_str + n, tmp_str_size - n, "|");
>