linux-kernel - Re: [PATCH v3 1/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos850

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqLAqSoVdExrHXZ4xVaY4Ut5R54izoumOY8zsXWN2e8++w@mail.gmail.com>
Date:   Sun, 8 Jan 2023 19:15:57 -0600
From:   Rob Herring <robh+dt@...nel.org>
To:     Sriranjani P <sriranjani.p@...sung.com>
Cc:     krzysztof.kozlowski+dt@...aro.org, devicetree@...r.kernel.org,
        alim.akhtar@...sung.com, pankaj.dubey@...sung.com,
        ravi.patel@...sung.com, sathya@...sung.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH v3 1/4] dt-bindings: soc: samsung: exynos-sysreg: add
 dedicated SYSREG compatibles to Exynos850

On Tue, Dec 13, 2022 at 10:47 PM Sriranjani P <sriranjani.p@...sung.com> wrote:
>
> Exynos850 has two different SYSREGs, hence add dedicated compatibles for
> them and deprecate usage of generic Exynos850 compatible alone.
>
> Signed-off-by: Sriranjani P <sriranjani.p@...sung.com>
> ---
>  .../soc/samsung/samsung,exynos-sysreg.yaml        | 15 ++++++++++++---
>  1 file changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> index 4954790eda6c..427df05224e5 100644
> --- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> @@ -17,7 +17,6 @@ properties:
>                - samsung,exynos3-sysreg
>                - samsung,exynos4-sysreg
>                - samsung,exynos5-sysreg
> -              - samsung,exynos850-sysreg
>                - samsung,exynosautov9-sysreg
>                - tesla,fsd-cam-sysreg
>                - tesla,fsd-fsys0-sysreg
> @@ -33,9 +32,17 @@ properties:
>            - const: samsung,exynos5433-sysreg
>            - const: syscon
>        - items:
> -          - const: samsung,exynos5433-sysreg
> +          - enum:
> +              - samsung,exynos5433-sysreg
> +              - samsung,exynos850-sysreg
> +          - const: syscon
> +            deprecated: true

This is throwing an error in linux-next now.

How can 1 item in a list be deprecated? What's the not deprecated
value for the entry? Probably this needs to move up to 'items' as the
whole entry is deprecated.

> +      - items:
> +          - enum:
> +              - samsung,exynos850-cmgp-sysreg
> +              - samsung,exynos850-peri-sysreg
> +          - const: samsung,exynos850-sysreg
>            - const: syscon
> -        deprecated: true
>
>    reg:
>      maxItems: 1
> @@ -53,6 +60,8 @@ allOf:
>          compatible:
>            contains:
>              enum:
> +              - samsung,exynos850-cmgp-sysreg
> +              - samsung,exynos850-peri-sysreg
>                - samsung,exynos850-sysreg
>      then:
>        required:
> --
> 2.17.1
>