linux-kernel - Re: [PATCH v3 1/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos850

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c3c35b5e-ec85-1226-c7a7-53bf4bd83713@linaro.org>
Date:   Mon, 9 Jan 2023 09:37:05 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Rob Herring <robh+dt@...nel.org>,
        Sriranjani P <sriranjani.p@...sung.com>
Cc:     krzysztof.kozlowski+dt@...aro.org, devicetree@...r.kernel.org,
        alim.akhtar@...sung.com, pankaj.dubey@...sung.com,
        ravi.patel@...sung.com, sathya@...sung.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH v3 1/4] dt-bindings: soc: samsung: exynos-sysreg: add
 dedicated SYSREG compatibles to Exynos850

On 09/01/2023 02:15, Rob Herring wrote:
> On Tue, Dec 13, 2022 at 10:47 PM Sriranjani P <sriranjani.p@...sung.com> wrote:
>>
>> Exynos850 has two different SYSREGs, hence add dedicated compatibles for
>> them and deprecate usage of generic Exynos850 compatible alone.
>>
>> Signed-off-by: Sriranjani P <sriranjani.p@...sung.com>
>> ---
>>  .../soc/samsung/samsung,exynos-sysreg.yaml        | 15 ++++++++++++---
>>  1 file changed, 12 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
>> index 4954790eda6c..427df05224e5 100644
>> --- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
>> +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
>> @@ -17,7 +17,6 @@ properties:
>>                - samsung,exynos3-sysreg
>>                - samsung,exynos4-sysreg
>>                - samsung,exynos5-sysreg
>> -              - samsung,exynos850-sysreg
>>                - samsung,exynosautov9-sysreg
>>                - tesla,fsd-cam-sysreg
>>                - tesla,fsd-fsys0-sysreg
>> @@ -33,9 +32,17 @@ properties:
>>            - const: samsung,exynos5433-sysreg
>>            - const: syscon
>>        - items:
>> -          - const: samsung,exynos5433-sysreg
>> +          - enum:
>> +              - samsung,exynos5433-sysreg
>> +              - samsung,exynos850-sysreg
>> +          - const: syscon
>> +            deprecated: true
> 
> This is throwing an error in linux-next now.
> 
> How can 1 item in a list be deprecated? What's the not deprecated
> value for the entry? Probably this needs to move up to 'items' as the
> whole entry is deprecated.

I missed this. I'll fix it. I'll updated my dtschema and see the error now.

Best regards,
Krzysztof