| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <5206c520-1263-a5a4-8960-edd41aaf3175@ti.com>
Date: Mon, 9 Jan 2023 22:14:09 +0530
From: Aradhya Bhatia <a-bhatia1@...com>
To: Laurent Pinchart <laurent.pinchart@...asonboard.com>
CC: Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Tomi Valkeinen <tomba@...nel.org>,
Jyri Sarha <jyri.sarha@....fi>,
David Airlie <airlied@...il.com>,
Daniel Vetter <daniel@...ll.ch>,
Thierry Reding <thierry.reding@...il.com>,
Sam Ravnborg <sam@...nborg.org>,
Maxime Ripard <maxime@...no.tech>,
Liam Girdwood <lgirdwood@...il.com>,
Mark Brown <broonie@...nel.org>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
Paul Walmsley <paul.walmsley@...ive.com>,
Palmer Dabbelt <palmer@...belt.com>,
Albert Ou <aou@...s.berkeley.edu>,
Matthias Brugger <matthias.bgg@...il.com>,
Guo Ren <guoren@...nel.org>,
DRI Development List <dri-devel@...ts.freedesktop.org>,
Devicetree List <devicetree@...r.kernel.org>,
Linux Kernel List <linux-kernel@...r.kernel.org>,
Linux RISC-V List <linux-riscv@...ts.infradead.org>,
Linux ARM Kernel List <linux-arm-kernel@...ts.infradead.org>,
Linux Mediatek List <linux-mediatek@...ts.infradead.org>,
Linux C-SKY Arch List <linux-csky@...r.kernel.org>,
Nishanth Menon <nm@...com>,
Vignesh Raghavendra <vigneshr@...com>,
Rahul T R <r-ravikumar@...com>,
Devarsh Thakkar <devarsht@...com>,
Jai Luthra <j-luthra@...com>,
Jayesh Choudhary <j-choudhary@...com>
Subject: Re: [RFC PATCH 3/4] dt-bindings: panel: Introduce dual-link LVDS
panel
Hi Laurent,
Thank you for reviewing the patches!
On 08-Jan-23 12:26, Laurent Pinchart wrote:
> Hi Aradhya,
>
> Thank you for the patch.
>
> On Tue, Jan 03, 2023 at 12:16:14PM +0530, Aradhya Bhatia wrote:
>> Dual-link LVDS interfaces have 2 links, with even pixels traveling on
>> one link, and odd pixels on the other. These panels are also generic in
>> nature, with no documented constraints, much like their single-link
>> counterparts, "panel-lvds".
>>
>> Add a new compatible, "panel-dual-lvds", and a dt-binding document for
>> these panels.
>>
>> Signed-off-by: Aradhya Bhatia <a-bhatia1@...com>
>> ---
>> .../display/panel/panel-dual-lvds.yaml | 157 ++++++++++++++++++
>> MAINTAINERS | 1 +
>> 2 files changed, 158 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/display/panel/panel-dual-lvds.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/display/panel/panel-dual-lvds.yaml b/Documentation/devicetree/bindings/display/panel/panel-dual-lvds.yaml
>> new file mode 100644
>> index 000000000000..88a7aa2410be
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/display/panel/panel-dual-lvds.yaml
>> @@ -0,0 +1,157 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/display/panel/panel-dual-lvds.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Generic Dual-Link LVDS Display Panel
>> +
>> +maintainers:
>> + - Aradhya Bhatia <a-bhatia1@...com>
>> + - Thierry Reding <thierry.reding@...il.com>
>> +
>> +description: |
>> + A dual-LVDS interface is a dual-link connection with the even pixels
>> + traveling on one link, and the odd pixels traveling on the other.
>> +
>> +allOf:
>> + - $ref: panel-common.yaml#
>> + - $ref: /schemas/display/lvds.yaml/#
>> +
>> +properties:
>> + compatible:
>> + oneOf:
>> + - items:
>> + - enum:
>> + - lincolntech,lcd185-101ct
>> + - microtips,13-101hieb0hf0-s
>> + - const: panel-dual-lvds
>> + - const: panel-dual-lvds
>
> A device-specific compatible string should be required,
> "panel-dual-lvds" alone shouldn't be allowed. Otherwise it won't be
> possible to tell different models apart later should this be required.
>
Understood! Will make the fix in the next revision.
>> +
>> + ports:
>> + $ref: /schemas/graph.yaml#/properties/ports
>> +
>> + properties:
>> + port@0:
>> + $ref: /schemas/graph.yaml#/$defs/port-base
>> + unevaluatedProperties: false
>> + description: The sink for first set of LVDS pixels.
>> +
>> + properties:
>> + dual-lvds-odd-pixels:
>> + type: boolean
>> +
>> + dual-lvds-even-pixels:
>> + type: boolean
>> +
>> + oneOf:
>> + - required: [dual-lvds-odd-pixels]
>> + - required: [dual-lvds-even-pixels]
>> +
>> + port@1:
>> + $ref: /schemas/graph.yaml#/$defs/port-base
>> + unevaluatedProperties: false
>> + description: The sink for second set of LVDS pixels.
>> +
>> + properties:
>> + dual-lvds-even-pixels:
>> + type: boolean
>> +
>> + dual-lvds-odd-pixels:
>> + type: boolean
>> +
>> + oneOf:
>> + - required: [dual-lvds-even-pixels]
>> + - required: [dual-lvds-odd-pixels]
>> +
>> + allOf:
>> + - if:
>> + properties:
>> + port@0:
>> + properties:
>> + dual-lvds-odd-pixels: true
>> + required:
>> + - dual-lvds-odd-pixels
>> + then:
>> + properties:
>> + port@1:
>> + properties:
>> + dual-lvds-even-pixels: true
>> + dual-lvds-odd-pixels: false
>> +
>> + - if:
>> + properties:
>> + port@0:
>> + properties:
>> + dual-lvds-even-pixels: true
>> + required:
>> + - dual-lvds-even-pixels
>> + then:
>> + properties:
>> + port@1:
>> + properties:
>> + dual-lvds-odd-pixels: true
>> + dual-lvds-even-pixels: false
>> +
>> + required:
>> + - port@0
>> + - port@1
>> +
>> + port: false
>> +
>> +unevaluatedProperties: false
>> +
>> +required:
>> + - compatible
>> + - width-mm
>> + - height-mm
>> + - data-mapping
>> + - panel-timing
>> + - ports
>> +
>> +examples:
>> + - |+
>> + panel-dual-lvds {
>> + compatible = "microtips,13-101hieb0hf0-s", "panel-dual-lvds";
>> +
>> + width-mm = <217>;
>> + height-mm = <136>;
>> +
>> + data-mapping = "vesa-24";
>> +
>> + panel-timing {
>> + clock-frequency = <150275000>;
>> + hactive = <1920>;
>> + vactive = <1200>;
>> + hfront-porch = <32>;
>> + hsync-len = <52>;
>> + hback-porch = <24>;
>> + vfront-porch = <24>;
>> + vsync-len = <8>;
>> + vback-porch = <3>;
>> + de-active = <1>;
>> + };
>> +
>> + ports {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + port@0 {
>> + reg = <0>;
>> + dual-lvds-odd-pixels;
>> + lcd_in0: endpoint {
>> + remote-endpoint = <&oldi_out0>;
>> + };
>> + };
>> +
>> + port@1 {
>> + reg = <1>;
>> + dual-lvds-even-pixels;
>> + lcd_in1: endpoint {
>> + remote-endpoint = <&oldi_out1>;
>> + };
>> + };
>> + };
>> + };
>> +
>> +...
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 7f86d02cb427..c13f24293ab1 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -6595,6 +6595,7 @@ T: git git://anongit.freedesktop.org/drm/drm-misc
>> S: Maintained
>> F: drivers/gpu/drm/panel/panel-lvds.c
>> F: Documentation/devicetree/bindings/display/lvds.yaml
>> +F: Documentation/devicetree/bindings/display/panel/panel-dual-lvds.yaml
>> F: Documentation/devicetree/bindings/display/panel/panel-lvds.yaml
>>
>> DRM DRIVER FOR MANTIX MLAF057WE51 PANELS
>
Regards
Aradhya
Powered by blists - more mailing lists