linux-kernel - Re: [PATCH v3 13/13] usb/serial: Rename dtr/rts parameters/variables to active

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y77rKQfIYyiPwz3S@hovoldconsulting.com>
Date:   Wed, 11 Jan 2023 18:00:25 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc:     linux-serial@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        Samuel Iglesias Gonsálvez 
        <siglesias@...lia.com>, Rodolfo Giometti <giometti@...eenne.com>,
        Oliver Neukum <oneukum@...e.com>, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 13/13] usb/serial: Rename dtr/rts parameters/variables
 to active

On Wed, Jan 11, 2023 at 04:23:31PM +0200, Ilpo Järvinen wrote:
> Use active consistently for naming parameters and variables.
> This converts all USB serial drivers + CDC-ACM.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> ---
>  drivers/usb/class/cdc-acm.c          | 4 ++--
>  drivers/usb/serial/ch341.c           | 4 ++--
>  drivers/usb/serial/cp210x.c          | 6 +++---
>  drivers/usb/serial/cypress_m8.c      | 6 +++---
>  drivers/usb/serial/digi_acceleport.c | 6 +++---
>  drivers/usb/serial/f81232.c          | 4 ++--
>  drivers/usb/serial/f81534.c          | 4 ++--
>  drivers/usb/serial/ftdi_sio.c        | 6 +++---
>  drivers/usb/serial/ipw.c             | 8 ++++----
>  drivers/usb/serial/keyspan.c         | 6 +++---
>  drivers/usb/serial/keyspan_pda.c     | 4 ++--
>  drivers/usb/serial/mct_u232.c        | 6 +++---
>  drivers/usb/serial/mxuport.c         | 4 ++--
>  drivers/usb/serial/pl2303.c          | 4 ++--
>  drivers/usb/serial/quatech2.c        | 6 +++---
>  drivers/usb/serial/sierra.c          | 6 +++---
>  drivers/usb/serial/spcp8x5.c         | 4 ++--
>  drivers/usb/serial/ssu100.c          | 6 +++---
>  drivers/usb/serial/upd78f0730.c      | 4 ++--
>  drivers/usb/serial/usb-serial.c      | 4 ++--
>  drivers/usb/serial/usb-wwan.h        | 2 +-
>  drivers/usb/serial/usb_wwan.c        | 6 +++---
>  drivers/usb/serial/xr_serial.c       | 4 ++--
>  23 files changed, 57 insertions(+), 57 deletions(-)

You should split this up as CDC-ACM is not a USB serial driver.

But this all seem like unnecessary churn to me. It was one thing
changing the parameter name in drivers that used something ambiguous
like 'on_off' but 'on' is just as clear as 'active' (and its shorter
too).

So please drop at least the USB serial changes as all drivers already
use 'on' consistently. 

Johan