linux-kernel - Re: [PATCH v3 08/13] tty/serial: Make ->dcd_change()+uart_handle_dcd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y77xj6Lk06m27X8J@hovoldconsulting.com>
Date:   Wed, 11 Jan 2023 18:27:43 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc:     linux-serial@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        Samuel Iglesias Gonsálvez 
        <siglesias@...lia.com>, Rodolfo Giometti <giometti@...eenne.com>,
        "David S. Miller" <davem@...emloft.net>,
        linux-kernel@...r.kernel.org, sparclinux@...r.kernel.org,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH v3 08/13] tty/serial: Make
 ->dcd_change()+uart_handle_dcd_change() status bool active

On Wed, Jan 11, 2023 at 04:23:26PM +0200, Ilpo Järvinen wrote:
> Convert status parameter for ->dcd_change() and
> uart_handle_dcd_change() to bool which matches to how the parameter is
> used.
> 
> Rename status to active to better describe what the parameter means.
> 
> Acked-by: Rodolfo Giometti <giometti@...eenne.com>
> Reviewed-by: Jiri Slaby <jirislaby@...nel.org>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> ---
>  drivers/pps/clients/pps-ldisc.c  |  6 +++---
>  drivers/tty/serial/serial_core.c |  8 ++++----
>  drivers/tty/serial/sunhv.c       |  8 ++++----
>  drivers/usb/serial/generic.c     | 10 +++++-----
>  include/linux/serial_core.h      |  3 +--
>  include/linux/tty_ldisc.h        |  4 ++--
>  include/linux/usb/serial.h       |  2 +-
>  7 files changed, 20 insertions(+), 21 deletions(-)

Same here, split out the USB serial changes in a separate series.

Johan