linux-kernel - RE: [PATCH v5 1/5] x86/cpufeature: add the cpu feature bit for LKGS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 11 Jan 2023 18:18:38 +0000
From:   "Li, Xin3" <xin3.li@...el.com>
To:     Borislav Petkov <bp@...en8.de>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "x86@...nel.org" <x86@...nel.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
        "hpa@...or.com" <hpa@...or.com>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "brgerst@...il.com" <brgerst@...il.com>,
        "Bae, Chang Seok" <chang.seok.bae@...el.com>,
        "Gross, Jurgen" <jgross@...e.com>
Subject: RE: [PATCH v5 1/5] x86/cpufeature: add the cpu feature bit for LKGS

> > Add the CPU feature bit for LKGS (Load "Kernel" GS).
> >
> > LKGS instruction is introduced with Intel FRED (flexible return and
> > event delivery) specificaton
> 
> Unknown word [specificaton] in commit message.
> Suggestions: ['specification',
> 
> Please use a spellchecker for your commit messages.
> 
> > https://cdrdv2.intel.com/v1/dl/getContent/678938.
> 
> This URL is most likely going to be unstable.
> 
> Write instead
> 
> "Search for the latest spec in most search engines by doing:
> 
> site:intel.com FRED (flexible return and event delivery) specification"

Thanks for the suggestion.

> Google etc has indexed it already so it should always pull out the newest revision.
> 
> $ test-apply.sh /tmp/01-x86-cpufeature-add_the_cpu_feature_bit_for_lkgs-
> new.patch
> checking file arch/x86/include/asm/cpufeatures.h
> Hunk #1 FAILED at 311.
> 1 out of 1 hunk FAILED
> checking file tools/arch/x86/include/asm/cpufeatures.h
> Hunk #1 FAILED at 308.
> 1 out of 1 hunk FAILED
> Apply? (y/n)
> 
> I guess you'd need to refresh the patchset against latest tip/master.

Will rebase on top of latest master and send v6 of the patch set.

Xin
 
> Thx.
> 
> --
> Regards/Gruss,
>     Boris.
> 
> https://people.kernel.org/tglx/notes-about-netiquette