linux-kernel - Re: [PATCH v3 2/3] arm64: dts: ti: k3-am62-main: Add support for USB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <078417fd-9e32-18b8-7bf5-d8d0fbe09dcf@ti.com>
Date:   Wed, 11 Jan 2023 23:50:43 +0530
From:   "Raghavendra, Vignesh" <vigneshr@...com>
To:     Sjoerd Simons <sjoerd@...labora.com>, Nishanth Menon <nm@...com>
CC:     <kernel@...labora.com>, Nitin Yadav <n-yadav@...com>,
        <martyn.welch@...labora.com>,
        Aswath Govindraju <a-govindraju@...com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Tero Kristo <kristo@...nel.org>, <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 2/3] arm64: dts: ti: k3-am62-main: Add support for USB



On 1/11/2023 6:53 PM, Sjoerd Simons wrote:
> From: Aswath Govindraju <a-govindraju@...com>
> 
> AM62 SoC has two instances of USB on it. Therefore, add support for the
> same.
> 
> Signed-off-by: Aswath Govindraju <a-govindraju@...com>
> Signed-off-by: Vignesh Raghavendra <vigneshr@...com>
> [cherry-pick from vendor BSP]]
> Signed-off-by: Sjoerd Simons <sjoerd@...labora.com>
> Tested-by: Martyn Welch <martyn.welch@...labora.com>
> 
> ---
> 
> Changes in v3:
> - Rebased against current ti-next aka 6.2-rc1
> - Add Martyn's tested-by
> 
> Changes in v2:
> - Rebase against linux-next 20221220
> 
>  arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 44 ++++++++++++++++++++++++
>  1 file changed, 44 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> index 466b94d1cee9..4da15e8c956f 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> @@ -555,6 +555,50 @@ sdhci2: mmc@...0000 {
>  		status = "disabled";
>  	};
>  
> +	usbss0: dwc3-usb@...0000 {
> +		compatible = "ti,am62-usb";
> +		reg = <0x00 0x0f900000 0x00 0x800>;
> +		clocks = <&k3_clks 161 3>;
> +		clock-names = "ref";
> +		ti,syscon-phy-pll-refclk = <&wkup_conf 0x4008>;
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		power-domains = <&k3_pds 178 TI_SCI_PD_EXCLUSIVE>;
> +		ranges;
> +

Following the convention of the file, could you please set status =
"disabled" here and then set it to okay in board dts file (patch 3/3)

> +		usb0: usb@...00000 {
> +			compatible = "snps,dwc3";
> +			reg =<0x00 0x31000000 0x00 0x50000>;
> +			interrupts = <GIC_SPI 188 IRQ_TYPE_LEVEL_HIGH>, /* irq.0 */
> +				     <GIC_SPI 188 IRQ_TYPE_LEVEL_HIGH>; /* irq.0 */
> +			interrupt-names = "host", "peripheral";
> +			maximum-speed = "high-speed";
> +			dr_mode = "otg";
> +		};
> +	};
> +
> +	usbss1: dwc3-usb@...0000 {
> +		compatible = "ti,am62-usb";
> +		reg = <0x00 0x0f910000 0x00 0x800>;
> +		clocks = <&k3_clks 162 3>;
> +		clock-names = "ref";
> +		ti,syscon-phy-pll-refclk = <&wkup_conf 0x4018>;
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		power-domains = <&k3_pds 179 TI_SCI_PD_EXCLUSIVE>;
> +		ranges;
> +

Same here...

> +		usb1: usb@...00000 {
> +			compatible = "snps,dwc3";
> +			reg =<0x00 0x31100000 0x00 0x50000>;
> +			interrupts = <GIC_SPI 226 IRQ_TYPE_LEVEL_HIGH>, /* irq.0 */
> +				     <GIC_SPI 226 IRQ_TYPE_LEVEL_HIGH>; /* irq.0 */
> +			interrupt-names = "host", "peripheral";
> +			maximum-speed = "high-speed";
> +			dr_mode = "otg";
> +		};
> +	};
> +
>  	fss: bus@...0000 {
>  		compatible = "simple-bus";
>  		reg = <0x00 0x0fc00000 0x00 0x70000>;