linux-kernel - Re: [PATCH 1/1] hwmon: remove unnecessary (void*) conversions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <db4276db-bbec-142a-d306-928421eb49fc@roeck-us.net>
Date:   Tue, 10 Jan 2023 19:29:20 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     XU pengfei <xupengfei@...china.com>, jdelvare@...e.com
Cc:     linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] hwmon: remove unnecessary (void*) conversions

On 1/10/23 18:07, XU pengfei wrote:
> Pointer variables of void * type do not require type cast.
> 

One patch per driver, and include the driver name (ibmpex, powr1220)
in the subject.

Guenter

> Signed-off-by: XU pengfei <xupengfei@...china.com>
> ---
>   drivers/hwmon/ibmpex.c   | 2 +-
>   drivers/hwmon/powr1220.c | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hwmon/ibmpex.c b/drivers/hwmon/ibmpex.c
> index 1837cccd993c..db066b368918 100644
> --- a/drivers/hwmon/ibmpex.c
> +++ b/drivers/hwmon/ibmpex.c
> @@ -546,7 +546,7 @@ static void ibmpex_bmc_gone(int iface)
>   
>   static void ibmpex_msg_handler(struct ipmi_recv_msg *msg, void *user_msg_data)
>   {
> -	struct ibmpex_bmc_data *data = (struct ibmpex_bmc_data *)user_msg_data;
> +	struct ibmpex_bmc_data *data = user_msg_data;
>   
>   	if (msg->msgid != data->tx_msgid) {
>   		dev_err(data->bmc_device,
> diff --git a/drivers/hwmon/powr1220.c b/drivers/hwmon/powr1220.c
> index f77dc6db31ac..501337ee5aa3 100644
> --- a/drivers/hwmon/powr1220.c
> +++ b/drivers/hwmon/powr1220.c
> @@ -174,7 +174,7 @@ static umode_t
>   powr1220_is_visible(const void *data, enum hwmon_sensor_types type, u32
>   		    attr, int channel)
>   {
> -	struct powr1220_data *chip_data = (struct powr1220_data *)data;
> +	struct powr1220_data *chip_data = data;
>   
>   	if (channel >= chip_data->max_channels)
>   		return 0;