linux-kernel - Re: [PATCH] staging: r8188eu: remove NULL check for usb_kill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b910456d-6306-d532-224e-81f862636930@gmail.com>
Date:   Wed, 11 Jan 2023 23:09:47 +0100
From:   Philipp Hortmann <philipp.g.hortmann@...il.com>
To:     Martin Kaiser <martin@...ser.cx>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        Michael Straube <straube.linux@...il.com>,
        Pavel Skripkin <paskripkin@...il.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: r8188eu: remove NULL check for usb_kill_urb

On 1/11/23 11:02, Martin Kaiser wrote:
> usb_kill_urb handles a NULL parameter. There's no need for NULL checks
> before we call usb_kill_urb.
> 
> Signed-off-by: Martin Kaiser <martin@...ser.cx>
> ---
>   drivers/staging/r8188eu/os_dep/usb_ops_linux.c | 9 +++------
>   1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/os_dep/usb_ops_linux.c b/drivers/staging/r8188eu/os_dep/usb_ops_linux.c
> index 62106d2f82ad..583533631133 100644
> --- a/drivers/staging/r8188eu/os_dep/usb_ops_linux.c
> +++ b/drivers/staging/r8188eu/os_dep/usb_ops_linux.c
> @@ -29,8 +29,7 @@ void rtw_read_port_cancel(struct adapter *padapter)
>   
>   	for (i = 0; i < NR_RECVBUFF; i++) {
>   		precvbuf->reuse = true;
> -		if (precvbuf->purb)
> -			usb_kill_urb(precvbuf->purb);
> +		usb_kill_urb(precvbuf->purb);
>   		precvbuf++;
>   	}
>   }
> @@ -153,15 +152,13 @@ void rtw_write_port_cancel(struct adapter *padapter)
>   	padapter->bWritePortCancel = true;
>   
>   	for (i = 0; i < NR_XMITBUFF; i++) {
> -		if (pxmitbuf->pxmit_urb)
> -			usb_kill_urb(pxmitbuf->pxmit_urb);
> +		usb_kill_urb(pxmitbuf->pxmit_urb);
>   		pxmitbuf++;
>   	}
>   
>   	pxmitbuf = (struct xmit_buf *)padapter->xmitpriv.pxmit_extbuf;
>   	for (i = 0; i < NR_XMIT_EXTBUFF; i++) {
> -		if (pxmitbuf->pxmit_urb)
> -			usb_kill_urb(pxmitbuf->pxmit_urb);
> +		usb_kill_urb(pxmitbuf->pxmit_urb);
>   		pxmitbuf++;
>   	}
>   }


Tested-by: Philipp Hortmann <philipp.g.hortmann@...il.com> # Edimax N150